Skip to content

fix(deps): move prop-types to dependencies - #760

Draft
wanxiankai wants to merge 1 commit into
lawnstarter:masterfrom
wanxiankai:fix/prop-types-dependency
Draft

fix(deps): move prop-types to dependencies#760
wanxiankai wants to merge 1 commit into
lawnstarter:masterfrom
wanxiankai:fix/prop-types-dependency

Conversation

@wanxiankai

Copy link
Copy Markdown

Summary

Fixes #755.

Moves prop-types from devDependencies to dependencies because src/index.js imports it at runtime and /src is included in the published package.

Why

Package managers with strict dependency isolation, such as pnpm, do not let consumers resolve a package's dev dependencies. Since react-native-picker-select publishes src/index.js and that file imports prop-types, consumers need prop-types to be installed as a production dependency of this package.

Test plan

  • npm run lint
  • npm test -- --runInBand --watchman=false
  • git diff --check
  • npm_config_cache=/tmp/codex-npm-cache npm pack --dry-run --ignore-scripts --json

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3066d3d4-8d93-4aa2-9b46-63d759023622

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prop-types should be a production dependency

1 participant