NetBSD: Fix build when ncurses package is installed. - #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to lcn2/rogue5.4#51
Rogue does not detect Ncurses when it is installed as binary package and is located in another tree, such as /usr/pkg. FreeBSD is similarly, but uses /usr/local (which IMO is more correct, oh well). Either way, Rogue Makefile when testing for headers fails to include CPPFLAGS macros with -E, so anyone overriding macro (CPPFLAGS, LDFLAGS) from the make command line still would not detect NCurses or link correctly.
This change should address the header detection and clean NetBSD build with NCurses. FreeBSD is an exercise for the FreeBSD reader.