Skip to content

Two state Helmholtz Free Energy for T \neq 0 - #1478

Open
korolrom wants to merge 7 commits into
leanprover-community:masterfrom
korolrom:master
Open

Two state Helmholtz Free Energy for T \neq 0#1478
korolrom wants to merge 7 commits into
leanprover-community:masterfrom
korolrom:master

Conversation

@korolrom

@korolrom korolrom commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

If Temperature is assumed nonzero, the lemma twoState_helmholtzFreeEnergy_eq can be simplified further

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip.

Important: If a reviewer adds an awaiting-author label to your PR, once you have addressed the review comments, please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

@github-actions github-actions Bot added the t-statistical-mechanics Statistical mechanics label Aug 1, 2026

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment for this one

ring

/-- An instance of `twoState_helmholtzFreeEnergy_eq` assuming T ≠ 0 -/
lemma twoState_helmholtzFreeEnergy_eq_Tneq0 (E₀ E₁ : ℝ) (T : Temperature) (Th : T ≠ 0) :

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think twoState_helmholtzFreeEnergy_eq_T_neq_zero would be a better name for this(more fitting with convention)

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - approved

@jstoobysmith jstoobysmith added the ready-to-merge This PR is approved and will be merged shortly label Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is approved and will be merged shortly t-statistical-mechanics Statistical mechanics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants