USB Enumeration V2#100
Merged
Merged
Conversation
kammce
force-pushed
the
usb-enum-v2
branch
4 times, most recently
from
5cda782 to
716e0af
Compare
kammce
force-pushed
the
usb-enum-v2
branch
2 times, most recently
from
9f68ab9 to
f39f4d4
Compare
PhazonicRidley
requested changes
May 17, 2026
- Fix UB bug with bit_value operator= - Fix const for get() in bit_value
- Add configuration_totals struct to return both length and interface count - Update prepare_descriptors to return configuration_totals - Use actual interface count from prepare_descriptors in generate_configuration_descriptor - Fixes issue where second CDC interface wasn't properly enumerated
PhazonicRidley
approved these changes
Jun 3, 2026
PhazonicRidley
left a comment
PhazonicRidley
left a comment
There was a problem hiding this comment.
Looks good and pretty much what we went over a few weeks ago.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the USB enumerator to transition from host-event to bus-event based event handling, removes constraints on interface enumeration, and adds comprehensive API documentation.
Key Changes
on_host_eventtoon_bus_eventfor better event handling modelinplace_enumeratorfor more flexible device enumerationFile Changes
utils.hppfor better organization