Redesign provider setup and add Codex restart#226
Conversation
|
@HaydernCenterpoint Try to use the workspace View please :) |
|
Thank you @HaydernCenterpoint for this comprehensive provider UI redesign — the OAuth/API split and restart endpoint concept are valuable directions. A few items need work before this can land: (1) RU locale key parity is missing (new EN keys without RU counterparts break We'll incorporate the design direction in a future iteration. Closing for now — thank you for the work. |
Detailed Review — PR #226What we reviewedWe ran an adversarial code review (Sol subagent, gpt-5.6-sol) that read the full FindingsThe design direction is valuable. Splitting the Providers page into side-by-side OAuth and API sections addresses a real UX problem — the current page mixes configured state with discovery UI, making it hard to scan what's actually connected. Moving discovery into a searchable two-column picker that excludes already-connected providers is a clean separation. The restart-recommendation flow after provider changes is also a good UX improvement. Four items need work before this can land:
Cross-PR interactions:
What we plan to adoptThe OAuth/API split design, the searchable provider picker, and the restart-after-connect concept are all directions we want to pursue. We'll build these on
Thank you @HaydernCenterpoint for this comprehensive work — the scope and quality of the redesign show deep familiarity with the product surface. |
|
Superseded by #247, now based on dev. The replacement includes Russian locale parity, waits for the Codex restart to complete and reports platform failures, uses rendered React UI tests, and keeps the change focused on the guided Providers flow. Thank you for the review feedback. |
What
Why
The existing page mixed account and API-key setup in one surface and rendered every account-capable provider inline, even when it was not connected. That made configured state hard to scan and made provider discovery noisy. Provider changes could also leave Codex with a stale model catalog until users manually synchronized and restarted the app.
Root cause
The catalog treated a provider's primary auth mode as its only setup capability, while the page used the full account-provider list as both configured state and discovery UI. There was also no dedicated local Codex Desktop restart action, and post-login refreshes updated only part of the Codex integration state.
Impact
Checks
bun test tests/codex-app-restart.test.ts tests/provider-workspace-auth.test.ts tests/provider-workspace-data.test.ts tests/provider-registry-parity.test.ts— 93 passed.bun run typecheck— passed.cd gui && bun run lint— passed.cd gui && bun run build— passed (existing chunk-size warning only).bun run privacy:scan— passed.printfcommand on Windows.