fix(gui): remove non-actionable API-key rows from Accounts tab#231
Merged
Merged
Conversation
The Accounts tab in the add-provider modal was showing API-key providers (hasApiKey or keyOptional) as rows with no buttons or actions. The ProviderCatalog renders kind:'key' rows with null in the actions column, making them dead weight that confuses users. API-key providers already appear in the Free/Paid tabs where they can be configured. Remove them from the Accounts tab entirely.
Owner
|
Reviewed against current dev. This is a small, correct UI cleanup: API-key rows in the Accounts tab have no actionable account controls, while API-key management remains in the provider flow. Full CI is green and no security concern was found. Merging into dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Accounts tab in the add-provider modal was showing API-key providers (those with
hasApiKeyorkeyOptional) as rows with no buttons or actions. TheProviderCatalogcomponent renderskind: "key"rows withnullin the actions column, making them dead weight that confuses users.Fix
Removed the third group from
addModalAccountRowsingui/src/pages/Providers.tsx. API-key providers already appear in the Free/Paid tabs where they can actually be configured. They don't belong in the Accounts tab, which is meant for OAuth and Codex-forward account management.Verification
bun x tsc --noEmitpasses ingui/