Fix MiniMax split reasoning in Codex#431
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
✅ Target branch corrected This pull request now targets The |
d0275b9 to
d25eba5
Compare
🔒 Under maintainer review — detailed feedback incoming@lidge-jun (maintainer) has this PR in an active review pass. Please do not merge or close This PR is not part of the current integration batch. It is held back deliberately — Heads-up on rebasing: No action needed from you until then. Thanks for the contribution and for your patience. Review tracker: |
|
Thank you for keeping this as a draft while adding MiniMax's split-reasoning request capability. Before marking it ready for review, please fix the response-ordering regression and tighten the scope/test contract.
The current I traced the one-line additions in Although this pinned patch currently passes Current Reviewed as part of a maintainer integration pass. |
d25eba5 to
9568cb8
Compare
What changed
devreasoningSplitModelscapability, which sendsreasoning_split: truefor supported OpenAI-compatible chat modelsthinking.type=disabledand medium/higher effort tothinking.type=adaptivereasoning_raw_deltais emitted before final text when one response carries both fieldsScope and security
The OAuth, key-login, and safe-config DTO edits only propagate
reasoningSplitModelsthrough existing provider-field whitelists. They do not change OAuth behavior, authentication policy, CORS policy, credential handling, or logging.Regression coverage
[DONE],finish_reason, or usage remains fail-closedValidation
bun run typecheckbun run testbun run privacy:scanbun run lint:guiThe PR remains a draft pending CI and maintainer review.