chore(gui): document intentional react-doctor policy disables#481
Conversation
Keep doctor.config.json rule disables and the rationale in .react-doctor-ignores.md separate from the code-fix PR so reviewers can weigh SPA architecture tradeoffs without blocking correctness/a11y landings.
|
Warning Review limit reached
Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Ingwannu
left a comment
There was a problem hiding this comment.
Reviewed at exact head b13f2790df75718535a8993208f3aac168c9fe02. This is policy/docs only: #480 is already merged, the config now runs React Doctor over the full GUI, and every disabled rule has a concrete architecture-debt rationale plus a re-enable condition. No runtime behavior changes. All current checks, including the full React Doctor job and cross-platform suite, are green.
Summary
gui/doctor.config.jsonwith intentional rule disables for SPA architecture patterns that are not worth a data-layer rewrite in this pass (fetch-in-effect, giant components / useReducer, parent sync effects, draft JSON editor derived state, etc.).gui/.react-doctor-ignores.mddocumenting the rationale for each disable.Why separate
Keeps policy tradeoffs reviewable on their own. The companion code-fix PR (#480) can merge on correctness/a11y merit without bundling rule disables; full react-doctor 100/100 needs this PR on top of those code fixes.
Test plan
gui/doctor.config.json,gui/.react-doctor-ignores.md)npx react-doctor@0.9.1 --scope fullingui/→ 100/100, 0 diagnostics.react-doctor-ignores.mdrationaleRelated