Skip to content

chore(gui): document intentional react-doctor policy disables#481

Merged
Ingwannu merged 1 commit into
lidge-jun:devfrom
Wibias:fix/react-doctor-policy
Jul 26, 2026
Merged

chore(gui): document intentional react-doctor policy disables#481
Ingwannu merged 1 commit into
lidge-jun:devfrom
Wibias:fix/react-doctor-policy

Conversation

@Wibias

@Wibias Wibias commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Doctor policy only — no runtime/GUI code changes.
  • Updates gui/doctor.config.json with intentional rule disables for SPA architecture patterns that are not worth a data-layer rewrite in this pass (fetch-in-effect, giant components / useReducer, parent sync effects, draft JSON editor derived state, etc.).
  • Adds gui/.react-doctor-ignores.md documenting the rationale for each disable.

Why separate

Keeps policy tradeoffs reviewable on their own. The companion code-fix PR (#480) can merge on correctness/a11y merit without bundling rule disables; full react-doctor 100/100 needs this PR on top of those code fixes.

Test plan

  • Diff is config/docs only (gui/doctor.config.json, gui/.react-doctor-ignores.md)
  • With fix(gui): clear remaining react-doctor code findings #480 merged (or stacked locally), npx react-doctor@0.9.1 --scope full in gui/ → 100/100, 0 diagnostics
  • Review each disable against .react-doctor-ignores.md rationale

Related

Keep doctor.config.json rule disables and the rationale in .react-doctor-ignores.md separate from the code-fix PR so reviewers can weigh SPA architecture tradeoffs without blocking correctness/a11y landings.
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Wibias, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 96359672-8cb0-4ecf-a820-d61325d7e769

📥 Commits

Reviewing files that changed from the base of the PR and between ac3af3e and b13f279.

📒 Files selected for processing (2)
  • gui/.react-doctor-ignores.md
  • gui/doctor.config.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Ingwannu Ingwannu left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at exact head b13f2790df75718535a8993208f3aac168c9fe02. This is policy/docs only: #480 is already merged, the config now runs React Doctor over the full GUI, and every disabled rule has a concrete architecture-debt rationale plus a re-enable condition. No runtime behavior changes. All current checks, including the full React Doctor job and cross-platform suite, are green.

@Ingwannu
Ingwannu merged commit 33693ce into lidge-jun:dev Jul 26, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants