fix(#532): align window total schema mapping#541
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
==========================================
+ Coverage 75.54% 75.55% +0.01%
==========================================
Files 444 444
Lines 58791 58791
Branches 9132 9132
==========================================
+ Hits 44411 44418 +7
+ Misses 11506 11500 -6
+ Partials 2874 2873 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #532.
select_with_total(count_with_window=True)window rows through the normal schema conversion path in both sync and async drivers._add_count_over_column()and_extract_total_from_rows()unchanged; the generated SQL was already correct.msgspec.Structschemas that omit an extra selected column.Root Cause
The two-query path used
SQLResult.get_data(schema_type=...), but the window-count path stripped_total_countand then constructed schema objects directly withschema_type(**row). Directmsgspec.Structconstruction rejects unmapped columns, while the normal SQLSpec conversion path tolerates them.