Conversation
- 跨座位残留候选不再误报 entityOverflow - 全暗来源跳过无展示价值的 N 选 K，回退默认暗牌移动 - 有观测快照时用 O(1) total/unknown 判断，避免手牌全表扫描 - 补充清议弃牌堆回填与随机转移回归
* fix(tracker): secondary hand transfer * chore: 修改 手牌框 UI 宽度
…f github.com:llsccm/tracker into dev
* fix(tracker): 手气卡回牌堆真正匿名化 resetKnownToUnknown 仅 isKnown=false 会在牌堆留下正 ID 未知槽， 后续暗摸会原样绑成正 ID 独占暗手并破坏 discardKnown 物化。 * fix(doudizhu): 不再用叫分结果误设先手 Type 44 只是叫分操作回包，不是最终地主结果；误用其 SeatID 设置先手。 * test(doudizhu): 对齐叫分回包不再设置先手的断言 Type 44/45 不再调用 setTrackerFirstHand，更新 roleSpellOptRep 回归。 * fix(tracker): 匿名化时经候选路径清空座位 直接清空 locationCandidates 不会同步 owner，seats 会回退旧座位。
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughTracker 更新了已定位身份的匿名化回收、随机手牌候选传播、座位候选扩展及相关测试；角色技能回包不再设置先手，并同步调整界面样式、DOM 判断和匿名槽归档文档。 ChangesTracker 身份与候选传播
角色技能回包处理
界面样式与文档记录
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant moveKnownCardsForContext
participant Room
participant CardCounter
moveKnownCardsForContext->>Room: anonymizeLocatedIdentity(card)
Room->>CardCounter: releaseLocatedIdentityToUnknown(card, previousCardID)
Room-->>moveKnownCardsForContext: previousCardID
moveKnownCardsForContext->>moveKnownCardsForContext: reset card and record resetKnownCardIDs
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/tracker/Room.ts (1)
535-547: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win
notifyCardChanged会立即撤销releaseLocatedIdentityToUnknown刚做的 dirty 清理。
releaseLocatedIdentityToUnknown末尾this.dirtyCards.delete(card)意味着"该卡状态已手动同步完毕"，但紧随其后调用的this.notifyCardChanged(...)内部会markCounterDirty(card)，把它重新放回dirtyCards。目前因为调用方（roomMovement.ts）紧接着执行card.reset()，且真正的counter.update()总在 reset 完成之后才跑，两次计算结果一致，不会有实际问题；但这是一处脆弱的顺序耦合——一旦未来在 anonymize 与 reset 之间插入任何触发counter.update()的读操作，该卡会被重新算成APPEARED而非UNKNOWN。建议把
counter.releaseLocatedIdentityToUnknown(...)调整到notifyCardChanged(...)之后执行，使"已同步"的删除操作始终是最后一步。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/tracker/Room.ts` around lines 535 - 547, 在包含 card-identity-anonymized 通知的流程中，将 counter.releaseLocatedIdentityToUnknown(card, previousCardID) 移到 notifyCardChanged(card, ...) 之后执行；保留无 counter 时调用 markCounterDirty(card) 的分支，并确保 releaseLocatedIdentityToUnknown 的 dirty 清理成为最后一步。
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/agents/card_tracker.md`:
- Line 235: 将匿名槽归档 plans/anonymous-entity-and-slot.md 纳入仓库可访问的位置并确保纳入版本控制；同步更新
docs/agents/card_tracker.md 第235行和第271行、docs/agents/testing.md
第136-138行中的引用，使三处链接都指向新的有效归档路径。
In `@src/tracker/roomMovement.ts`:
- Around line 698-712: The anonymization failure fallback in the known-card
reset flow is silent. In the resetKnownToUnknown branch of
moveKnownCardsForContext, when anonymizeLocatedIdentity returns null, add a
trackerLogger.warn that reports the card/index inconsistency before resetting
the card; preserve resetKnownCardIDs handling and do not introduce additional
behavior changes.
---
Nitpick comments:
In `@src/tracker/Room.ts`:
- Around line 535-547: 在包含 card-identity-anonymized 通知的流程中，将
counter.releaseLocatedIdentityToUnknown(card, previousCardID) 移到
notifyCardChanged(card, ...) 之后执行；保留无 counter 时调用 markCounterDirty(card) 的分支，并确保
releaseLocatedIdentityToUnknown 的 dirty 清理成为最后一步。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0b831e8d-89f6-4dbb-82fe-a0be71a54cb4
📒 Files selected for processing (20)
docs/agents/card_tracker.mddocs/agents/testing.mdhtml/iframe.htmlsrc/dom.jssrc/draw.jssrc/handler/CGsRoleSpellOptRep.jssrc/tracker/Card.tssrc/tracker/CardCounter.tssrc/tracker/MoveEventNormalizer.tssrc/tracker/Room.tssrc/tracker/roomMovement.tssrc/tracker/roomMovement/candidates.tssrc/tracker/roomMovement/types.tssrc/tracker/state.tstests/tracker/handCountObservation.test.tstests/tracker/locationCandidates.test.tstests/tracker/roleSpellOptRep.test.tstests/tracker/secondaryRandomHandTransfer.test.tstests/tracker/spellEffects.test.tstests/tracker/trackerController.test.ts
- resetKnownToUnknown 时 anonymize 失败记录 card/index 不一致 - releaseLocatedIdentityToUnknown 移到 notifyCardChanged 之后
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit