Fix arena moderation skipping right model conversation history#3889
Open
Chessing234 wants to merge 1 commit into
Open
Fix arena moderation skipping right model conversation history#3889Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
In side-by-side arena modes, moderation was reading states[0] twice instead of states[1] for the right model, and vision anony passed only the current user message instead of full conversation history. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In side-by-side arena mode, the moderation filter builds
all_conv_textfrom both models' histories before each turn. Two files had a copy-paste bug whereall_conv_text_rightreadstates[0](left model) instead ofstates[1](right model), so Model B's responses were never checked. The vision anonymous arena was worse — it passed the current user message asall_conv_text, so no prior history from either model was moderated.This matches the fix already in
gradio_block_arena_named.py(34eca62).Fixes #3834, #3794
Made with Cursor