Fix bugs with saving messages, and deleting messages and conversations#85
Merged
Conversation
never stored locally and thus never deletable, leaving conversations that couldn't be cleaned up. - chat-indexer: save all real messages (isMessageView) instead of filtering on text; skip only placeholders - getConversationMessageCount: count only real messageViews - delete-messages: run empty-conversation cleanup from the DB even with no messages to delete; schedule the job whenever deleteChats is on - FinishedModal: report conversations left - update tests/fixtures accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79
I noticed that empty conversations sometimes weren't being deleted, and some messages that were old also weren't being deleted. This fixes those.