Conversation
- Fix Prettier formatting in cyd-api-client.ts and UpsellComponent.test.ts - Update auth.test.ts to expect the broadened login URL "https://x.com/i/" (matching auth.ts) instead of the stale "https://x.com/i/flow/login" - Enable the feature flag in the AccountView Facebook tests so the Facebook card renders (it's gated behind isFeatureEnabled("bluesky")) - Fix flaky database/indexing tests: database.test.ts mocked getSettingsPath to the shared parent dir and its afterEach wiped every worker's worker-N subdirectory, deleting other suites' live databases mid-run. Make the mock respect the per-worker TEST_SETTINGS_PATH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, I gitignored
.codegraph(a new thing I'm trying out), and fixed the tests and made them less brittle.