Build debians for ARM64#12
Open
kronos30 wants to merge 1 commit into
Open
Conversation
Add ubuntu-22.04-arm and ubuntu-24.04-arm runners to the build matrix so the libpcl-all-dev Debian package is built and published for arm64 as well as amd64. Make the -march=haswell compiler flag conditional on the target architecture in build_deb.sh, since it is an x86-64 microarchitecture and is invalid on arm64. The JFrog upload already derives the architecture from dpkg --print-architecture, so arm64 packages are tagged and named correctly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR extends the Debian package build-and-publish workflow to produce and upload arm64 packages in addition to amd64, and updates the build script to avoid using an x86-specific -march flag when targeting non-x86 architectures.
Changes:
- Add ARM Ubuntu runners to the GitHub Actions build matrix so Debian packages are built for arm64.
- Make
-march=haswellconditional ondpkg --print-architectureso arm64 builds don’t receive an invalid compiler flag. - Log the detected Debian architecture during the build for easier troubleshooting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
build_deb.sh |
Detects target Debian architecture and conditionally applies x86-only -march=haswell to keep arm64 builds valid. |
.github/workflows/build-deb.yml |
Expands the build matrix to include ARM runners so arm64 .deb artifacts are built and uploaded to JFrog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is against @garyservin 's PR Here this is to included the ARM debians into git workflow upload into JFrog.
Add ubuntu-22.04-arm and ubuntu-24.04-arm runners to the build matrix so the libpcl-all-dev Debian package is built and published for arm64 as well as amd64.
Make the -march=haswell compiler flag conditional on the target architecture in build_deb.sh, since it is an x86-64 microarchitecture and is invalid on arm64. The JFrog upload already derives the architecture from dpkg --print-architecture, so arm64 packages are tagged and named correctly.