Implement Dns.lookup on Dns.newCall for DnsOverHttps#9568
Merged
Conversation
The lookup path is no longer exercised by OkHttp itself. This reduces potential drift between the two strategies.
swankjesse
commented
Jul 21, 2026
| * Call our asynchronous API synchronously. | ||
| * | ||
| * This returns normally if at least one [Dns.Record.IpAddress] is returned. Partial failures are | ||
| * silently ignored. |
Collaborator
Author
There was a problem hiding this comment.
This behaviour change impacts RoutePlanner! (RoutePlanner currently calls through this execute function.)
yschimke
reviewed
Jul 21, 2026
yschimke
reviewed
Jul 21, 2026
| ) | ||
| val call = withoutServiceMetadata.newCall(Dns.Request(hostname)) | ||
| val records = call.execute() | ||
| return records.filterIsInstance<Dns.Record.IpAddress>() |
yschimke
approved these changes
Jul 21, 2026
…HttpsTest.kt Co-authored-by: Yuri Schimke <yuri@schimke.ee>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lookup path is no longer exercised by OkHttp itself.
This reduces potential drift between the two strategies.