Document that the pacparser API is not thread-safe#247
Merged
Conversation
pacparser keeps all engine state in process-global variables and creates no threads of its own, so the API is single-instance and not thread-safe. Document the contract in the README and pacparser.h: callers must serialize all pacparser_* calls and must not call pacparser_cleanup() while another thread is in find_proxy()/parse_pac*(). Addresses GHSA-q2v4-fh98-357r. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pacparser.h.pacparser_*calls and must not callpacparser_cleanup()while another thread is infind_proxy()/parse_pac*().Addresses GHSA-q2v4-fh98-357r (docs half; mutex hardening is a separate PR).
Test plan
🤖 Generated with Claude Code