MLE-30265 add warning for BASIC auth without SSL#1093
Merged
Conversation
rjdew-progress
requested review from
BillFarber,
anu3990,
rjrudin and
stevebio
as code owners
There was a problem hiding this comment.
Pull request overview
Adds a runtime warning to help users avoid unintentionally sending MarkLogic BASIC-auth credentials over cleartext connections (no SSL/TLS).
Changes:
- Updates the copyright header year.
- Emits a warning during client initialization when
authTypeisBASICandsslis not enabled.
Comment on lines
+742
to
+744
| if (authType === 'BASIC' && !isSSL) { | ||
| console.warn('Authentication type is BASIC and SSL is not enabled. This may expose credentials.'); | ||
| } |
Comment on lines
+742
to
+744
| if (authType === 'BASIC' && !isSSL) { | ||
| console.warn('Authentication type is BASIC and SSL is not enabled. This may expose credentials.'); | ||
| } |
jonmille
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn users that the NodeJS will transmit MarkLogic credentials in cleartext over the network if authentication type BASIC is used without SSL/TLS.