fix: replace Cyrillic Ghe with Greek Gamma for defaultPoint - #159
Merged
Conversation
PointsPathFormDataProvider's defaultPoint must match whatever @mat3ra/made actually emits for the Brillouin-zone Gamma point in its symmetryPoints enum, or the JSON-schema select field defaults to a value outside its own enum. made emitted Cyrillic "Г" (U+0413) instead of Greek "Γ" (U+0393) - now fixed upstream (made PR #290, published as 2026.7.29-0) - so this defaultPoint needs the matching update. Also bumps the made/utils devDependency pins to their current published versions: made 2026.7.29-0 requires a newer @mat3ra/utils (Utils.math.unit) than wode's previous 2025.9.20-0 pin provided, surfacing as an unrelated "Utils.math.unit is not a function" failure in Lattice.calculateVectors once made was bumped to pick up the actual fix. Bumping utils to 2026.7.9-0 alongside made resolves it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PointsPathFormDataProvider'sdefaultPointmust match whatever@mat3ra/madeactually emits for the Brillouin-zone Gamma point in itssymmetryPointsenum, or the JSON-schema select field defaults to a value outside its own enum.madeemitted Cyrillic "Г" (U+0413) instead of Greek "Γ" (U+0393) — now fixed upstream (madePR #290, published as2026.7.29-0) — so thisdefaultPointneeds the matching update.made/utilsdevDependency pins to their current published versions:made@2026.7.29-0requires a newer@mat3ra/utils(Utils.math.unit) than wode's previous2025.9.20-0pin provided, surfacing as an unrelatedUtils.math.unit is not a functionfailure inLattice.calculateVectorsoncemadewas bumped to pick up the actual fix. Bumpingutilsto2026.7.9-0alongsidemaderesolves it.job-kpoint-path-vasp.feature, the GW band-gap spec,valence_band_offset.feature, andjob-espresso-valence-band-offset.feature.Test plan
npm test— 47/47 passingpytest tests/py— 81/81 passing@mat3ra/made@2026.7.29-0(not a local patch) — confirmed 0 Cyrillic / 1 Greek Gamma in the installed dist