RPCClient: clean up logging#244
Merged
Merged
Conversation
... instead of repeating it 100 times
Make the logging more consistent, and associate it with the relevant test. Also add a few comments about things I don't understand, or which need fixing.
We get a panic if they are written after the test finishes.
I don't understand why these are happening, but I don't think they are hugely important. Let's just log them and move on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the logging more consistent, and associate it with the relevant test.
In order to make that work right, we need to cleanly shut down the RPC server once it's been used in a test.
Also some light refactoring, and a few comments about things I don't understand, or which need fixing.
Suggest review commit-by-commit