Remove alerts hook#1045
Open
allisonking wants to merge 3 commits into
Open
Conversation
Alerts manager handles adding informed entities now
allisonking
commented
Jul 6, 2026
| route: route.id, | ||
| route_type: route.type, | ||
| direction_id: 1 | ||
| } |
Contributor
Author
There was a problem hiding this comment.
tbh I don't totally understand why I needed to make this change for the test to pass. I'm guessing the hook was adding this data in from the "trip" connection. but now we should get the full informed entity from alerts, so I put the whole informed entity here and that seemed to make the test happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: ☄️ Create additional informed entities for multi-route trips and 🧑🧒 Publish additional informed_entities for parent stops
Alerts manager now handles adding informed entities for both parent entities (https://github.com/mbta/alerts_ui/pull/1051) and alternate routes (https://github.com/mbta/alerts_ui/pull/1209). This takes out the hook so that API is no longer responsible for this behavior.
Some more context: previously I had removed parent entities only in #1042, but we decided we should just remove both parent and alternate entities in one go. It is mostly okay for the API to still be trying to add these, it'll just result in occasional duplicates like in this instance. I don't think alternate entities would ever be duplicated... 🤞 Alerts adding parents has been in prod for about a month now, and we just deployed alerts adding alternate routes to staging, so
api-dev-blueis handling it there.We need to trigger all the alerts to rebuild their informed entities with their new logic before this API code can safely go away. So I won't be merging this quite yet, but wanted it to be ready!