[codex] Add annotation authoring helpers#113
Closed
meekmachine wants to merge 1 commit into
Closed
Conversation
meekmachine
force-pushed
the
codex/annotation-authoring-apis
branch
from
April 26, 2026 00:46
4c1c383 to
8506e33
Compare
Owner
Author
PR backlog triage — CLOSE (abandoned)Abandoned draft with no active Embody/Polymer consumer. RuntimeCore/bindings work continues elsewhere; lip-sync planners belong in Polymer. Plan: meekmachine/Polymer#59 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109.
Summary
AnnotationRegionsupport persistedcustomPositionso the profile-level authoring shape matches the runtime region behavior more closelyannotationRegionsas the canonical authored annotation surface while keeping top-levelregionsas the current runtime/back-compat shapeWhy
The package already had most of the annotation data model and runtime extension path, but downstream apps still had to duplicate annotation merge and validation behavior in app code.
This change gives the SliderDrawer-side annotation editor work a package-level contract to build against and removes duplicate merge logic from the existing Loom3 extension helpers.
Validation
npm testnpm run typechecknpm run build