[codex] Harden dynamic clip parameter updates#137
Closed
meekmachine wants to merge 1 commit into
Closed
Conversation
meekmachine
force-pushed
the
codex/116-dynamic-clip-param-updates
branch
from
May 10, 2026 00:46
f7a843b to
8815245
Compare
Owner
Author
PR backlog triage — CLOSE (abandoned)Abandoned draft with no active Embody/Polymer consumer. RuntimeCore/bindings work continues elsewhere; lip-sync planners belong in Polymer. Plan: meekmachine/Polymer#59 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #116.
This hardens
updateClipParams()for scheduler-driven dynamic clips so active snippet/clip actions can be adjusted without rebuilding their underlying clips.What changed
actionIdas an exact selector instead of also updating broad name matches.repeatCountchanges.reverseupdates without requiring a simultaneous rate update.setEffectiveWeight().falseonly when no active clip/action target can be found.Validation
npx vitest run src/engines/three/AnimationThree.playbackState.test.tsnpm run typechecknpm testnpm run buildgit diff --check