Skip to content

[codex] Harden dynamic clip parameter updates#137

Closed
meekmachine wants to merge 1 commit into
mainfrom
codex/116-dynamic-clip-param-updates
Closed

[codex] Harden dynamic clip parameter updates#137
meekmachine wants to merge 1 commit into
mainfrom
codex/116-dynamic-clip-param-updates

Conversation

@meekmachine

Copy link
Copy Markdown
Owner

Summary

Fixes #116.

This hardens updateClipParams() for scheduler-driven dynamic clips so active snippet/clip actions can be adjusted without rebuilding their underlying clips.

What changed

  • Treat actionId as an exact selector instead of also updating broad name matches.
  • Dedupe the same mixer action when it appears in both internal action maps.
  • Preserve the current loop mode when only repeatCount changes.
  • Support reverse updates without requiring a simultaneous rate update.
  • Keep dynamic clip weight updates on the active mixer action through setEffectiveWeight().
  • Return false only when no active clip/action target can be found.
  • Add regression coverage for actionId targeting, no-rebuild weight updates, repeat/reverse updates, and missing action IDs.

Validation

  • npx vitest run src/engines/three/AnimationThree.playbackState.test.ts
  • npm run typecheck
  • npm test
  • npm run build
  • git diff --check

@meekmachine
meekmachine force-pushed the codex/116-dynamic-clip-param-updates branch from f7a843b to 8815245 Compare May 10, 2026 00:46
@meekmachine

Copy link
Copy Markdown
Owner Author

PR backlog triage — CLOSE (abandoned)

Abandoned draft with no active Embody/Polymer consumer. RuntimeCore/bindings work continues elsewhere; lip-sync planners belong in Polymer.

Plan: meekmachine/Polymer#59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose and harden direct clip parameter updates for scheduler-driven snippets

1 participant