feat!: move internal services status to health command#345
Open
augustoccesar wants to merge 1 commit into
Open
feat!: move internal services status to health command#345augustoccesar wants to merge 1 commit into
augustoccesar wants to merge 1 commit into
Conversation
For the normal use cases and day-to-day use, it feels like there is no need to have the internal Linkup services listed on `status`. Since they are more used to debug internal Linkup issues and not really the user normal uses, seems like `health` is a more appropriate place for it. This changes proposes removing internal services from the `status` command, and instead have them be shown on the `health` command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the normal use cases and day-to-day use, it feels like there is no need to have the internal Linkup services listed on
status. Since they are more used to debug internal Linkup issues and not really the user normal uses, seems likehealthis a more appropriate place for it.This changes proposes removing internal services from the
statuscommand, and instead have them be shown on thehealthcommand.