Skip to content

Run as meshtasticd user (not root)#20

Draft
vidplace7 wants to merge 1 commit into
mainfrom
meshtasticd-user
Draft

Run as meshtasticd user (not root)#20
vidplace7 wants to merge 1 commit into
mainfrom
meshtasticd-user

Conversation

@vidplace7

@vidplace7 vidplace7 commented Jun 15, 2025

Copy link
Copy Markdown
Member

DRAFT while I figure out udevhotplug.d for this.

@vidplace7
vidplace7 marked this pull request as draft June 15, 2025 13:21
@vidplace7
vidplace7 requested a review from Copilot June 15, 2025 23:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Meshtastic daemon to run as a dedicated meshtasticd user instead of root.

  • init script now chowns the data and config directories and sets the service user to meshtasticd
  • bumped PKG_RELEASE to 2 and added USERID metadata in the Makefile

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
meshtasticd/files/meshtasticd.init chown data/config dirs and configure procd to use meshtasticd user
meshtasticd/Makefile incremented release number and specified USERID
Comments suppressed due to low confidence (3)

meshtasticd/files/meshtasticd.init:23

  • Ensure that the meshtasticd user and group are created (e.g., via package install scripts) before running chown, otherwise the command may fail if the user/group doesn't exist.
chown -R meshtasticd:meshtasticd $DATA_DIR

meshtasticd/files/meshtasticd.init:24

  • Similarly, verify that $CONFIG_BASEDIR exists and that the meshtasticd user/group exist before applying chown, to prevent startup errors.
chown -R meshtasticd:meshtasticd $CONFIG_BASEDIR

meshtasticd/Makefile:48

  • Add a user-creation step (e.g., adduser/addgroup) in the package install phase so that the USERID variable has effect and avoids installation failures when the user is missing.
USERID:=meshtasticd:meshtasticd

@vidplace7
vidplace7 force-pushed the meshtasticd-user branch 3 times, most recently from c607608 to ee68292 Compare June 18, 2025 14:05
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ee187b35-6c94-4e5b-93d4-7a88116f710d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants