Ozzafar/issue 18 add breakpoint line#108
Merged
Merged
Conversation
Replace the substring-based `lineContent` parameter with a 1-based `line` number, making add_breakpoint consistent with remove_breakpoint, list_breakpoints, and the documented tool schema. The handler now validates the line (integer >= 1 and within the file's line count) and sets a single breakpoint at that line, failing clearly instead of substring-matching (which could set multiple/unexpected breakpoints). Updated the MCP tool schema, routing handler/test, README, SKILL.md, and the C# troubleshooting doc. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6ea24b92-40ad-4539-aa13-61aa6ff8751f
Extract the shared "race work against a timeout" logic used by DebuggingExecutor.dapRequest and DebugMCPServer.runTool into a tested withTimeout() utility (behavior preserved), and add regression coverage for the "server stuck when a tool call hangs" fix: - withTimeout.test.ts: resolves fast work, propagates work rejections, rejects with the caller's error when work hangs, and clears the timer so a late-but-eventual result still wins. - routing.test.ts: a control server that accepts but never responds must cause handleStartDebugging to reject with the actionable "did not respond within ... unresponsive" message. RoutingDebuggingHandler now accepts an optional forwardTimeoutMs override so the test runs fast. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6ea24b92-40ad-4539-aa13-61aa6ff8751f
✅ Extension Build Successful!📦 VSIX artifact is ready for download Scroll down to the "Artifacts" section and download To install: In VS Code, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.