Skip to content

fetches test models from azure storage blob#848

Open
prathikr wants to merge 16 commits into
mainfrom
prathikrao/fetch-test-data-from-blob
Open

fetches test models from azure storage blob#848
prathikr wants to merge 16 commits into
mainfrom
prathikrao/fetch-test-data-from-blob

Conversation

@prathikr

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 29, 2026 21:26
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
foundry-local Ready Ready Preview, Comment Jun 30, 2026 11:19pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the sdk_v2 test infrastructure away from cloning the test-data-shared Azure DevOps Git repo (LFS) and instead downloads the shared test model cache from Azure Blob Storage. Across all sdk_v2 languages (C++, C#, JS, Python), model-dependent tests are now gated on a required FOUNDRY_TEST_DATA_DIR environment variable, and the CI pipelines populate that directory via a new azcopy-based template. This unifies how the model cache is provided and removes the per-platform git-lfs bootstrapping that the repo checkout required.

Changes:

  • Adds .pipelines/templates/fetch-test-data-from-blob.yml, which uses AzureCLI@2 + azcopy (AZCLI auto-login) to download model data into a destination path, replacing checkout-steps.yml usage in v2 build/test stages (and dropping the macOS git-lfs install steps).
  • Makes FOUNDRY_TEST_DATA_DIR the single required source of the model cache: C++ GetTestModelCacheDir now throws if unset (removing the repo-root fallback), Python conftest.py skips when it's unset/missing, and C# Utils.cs drops the appsettings.Test.json fallback (and its config package references).
  • Updates developer docs (sdk_v2/DEVELOPMENT.md, LOCAL_MODEL_TESTING.md) to describe the new env-var workflow.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.pipelines/templates/fetch-test-data-from-blob.yml New template that azcopy-downloads test model data from blob storage
.pipelines/v2/templates/steps-build-{linux,macos,windows}.yml Replace test-data-shared checkout with blob fetch into $(Agent.BuildDirectory)/test-data-shared
.pipelines/v2/templates/stages-{cs,js,python}.yml Replace checkout + macOS git-lfs install with blob fetch in test stages
sdk_v2/cpp/test/internal_api/test_model_cache.h Require FOUNDRY_TEST_DATA_DIR; remove repo-root default fallback and FindRepoRoot
sdk_v2/cs/test/FoundryLocal.Tests/Utils.cs Require env var; remove appsettings-based fallback logic
sdk_v2/cs/test/FoundryLocal.Tests/Microsoft.AI.Foundry.Local.Tests.csproj Remove appsettings.Test.json copy and Microsoft.Extensions.Configuration packages
sdk_v2/cs/test/FoundryLocal.Tests/appsettings.Test.json Deleted (no longer used)
sdk_v2/cs/test/FoundryLocal.Tests/LOCAL_MODEL_TESTING.md Document env-var-based workflow
sdk_v2/python/test/conftest.py Skip model tests unless FOUNDRY_TEST_DATA_DIR is set and exists
sdk_v2/DEVELOPMENT.md Document the model cache requirement for tests

Comment thread .pipelines/templates/fetch-test-data-from-blob.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants