feat: add Azure Container Registry module, enhance deployment scripts and update model configuration.#469
Open
VishalSh-Microsoft wants to merge 1 commit into
Conversation
…, and update model configuration
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modularizes Azure Container Registry (ACR) provisioning to better support both public and WAF/private networking deployments, enhances the image build/push automation to handle private ACR scenarios more robustly, and updates configuration/docs to use gpt-5.1 as the default GPT model.
Changes:
- Introduces a dedicated
infra/modules/containerRegistry.bicepmodule and wires it intoinfra/main.bicep, including an ACR private DNS zone entry and updated DNS zone indexing. - Refactors the build-and-push scripts (Bash + PowerShell) to support both azd-output mode and explicit resource-group discovery, and to temporarily relax/restore ACR network restrictions for WAF/private deployments.
- Updates sample env/config and documentation/quota scripts to default to
gpt-5.1instead ofgpt-4o.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/backend/.env.sample | Updates default agent model deployment values to gpt-5.1. |
| scripts/quota_check_params.sh | Updates default model/capacity pair to gpt-5.1:150. |
| scripts/checkquota.sh | Updates the GlobalStandard quota key to gpt-5.1. |
| scripts/build_and_push_images.sh | Adds RG discovery + WAF/private ACR “relax/restore” flow and connectivity checks. |
| scripts/build_and_push_images.ps1 | Adds RG discovery + WAF/private ACR “relax/restore” flow and connectivity checks. |
| infra/modules/containerRegistry.bicep | New module implementing ACR + optional private endpoint + role assignments + telemetry. |
| infra/main.json | Regenerated ARM template reflecting the new ACR module + DNS zone/index updates. |
| infra/main.bicep | Switches ACR provisioning to the new module and adds privatelink.azurecr.io + index updates. |
| docs/quota_check.md | Updates documentation examples to reference gpt-5.1. |
| docs/EXAMPLE-CustomizingAzdParameters.md | Updates example to use AZURE_ENV_GPT_MODEL_NAME and gpt-5.1. |
| docs/CustomizingAzdParameters.md | Updates model name description to reflect gpt-5.1 default. |
| docs/AzureGPTQuotaSettings.md | Updates guidance to include GPT-5.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant improvements to the deployment and management of Azure Container Registry (ACR) resources, particularly enhancing support for both public and private (WAF) networking scenarios. It refactors the ACR provisioning into a dedicated Bicep module, updates documentation to reflect the new default GPT model (
gpt-5.1), and enhances the build and push script for container images to handle WAF/private networking deployments more robustly.Key changes include:
Infrastructure improvements (ACR and networking)
modules/containerRegistry.bicep), supporting both public and private (WAF) deployments, private endpoints, and role assignments. This makes the infrastructure more modular and maintainable. [1] [2]Build and deployment automation
build_and_push_images.ps1script to:Documentation updates
gpt-5.1as the default/allowed GPT model, replacinggpt-4o. [1] [2] [3] [4] [5] [6]Most important changes:
Infrastructure and Networking
containerRegistry.bicepmodule to manage ACR with both public and private networking, private endpoints, and role assignments.infra/main.bicepto use the new module, added ACR private DNS zone, and updated DNS zone index. [1] [2] [3]Build and Deployment Automation
build_and_push_images.ps1to support WAF/private ACR deployments by temporarily relaxing network rules during builds and restoring them afterward, and improved overall robustness and error handling.Documentation and Parameters
gpt-5.1the default/allowed GPT model, replacinggpt-4o. [1] [2] [3] [4] [5] [6]These changes significantly improve the flexibility, security, and maintainability of the deployment process and documentation.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation