chore: down merging the changes from main#471
Open
Abdul-Microsoft wants to merge 11 commits into
Open
Conversation
…d_and_push_images.sh) for building and pushing container images to ACR.
…dmod feat: Refactor infrastructure parameters and add image build scripts
Abdul-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
aniaroramsft,
dgp10801,
nchandhi and
toherman-msft
as code owners
Abdul-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Abdul-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the deployment flow by introducing per-deployment Azure Container Registry (ACR) provisioning and post-provision automation to build/push backend and frontend container images remotely via az acr build, while also updating default GPT model settings and refreshing related documentation/parameters.
Changes:
- Added post-provision scripts to build/push backend+frontend images in the deployment’s ACR and update Container Apps to use them.
- Updated infra templates/parameters to provision a dedicated ACR, use placeholder images initially, and expose outputs consumed by the scripts; removed the static registry endpoint parameter.
- Updated deployment docs and parameter docs; refreshed default GPT model name/version; updated CODEOWNERS.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/build_and_push_images.sh | Adds Bash automation to ACR-build images and update Container Apps. |
| scripts/build_and_push_images.ps1 | Adds PowerShell automation to ACR-build images and update Container Apps. |
| infra/main.waf.parameters.json | Removes static container registry endpoint parameter. |
| infra/main.parameters.json | Removes static container registry endpoint parameter. |
| infra/main.json | Updates generated ARM template to include per-deployment ACR, placeholder images, and new outputs. |
| infra/main.bicep | Provisions dedicated ACR, switches Container Apps to placeholder images, and adds outputs for the post-provision scripts; updates GPT defaults. |
| infra/main_custom.bicep | Updates GPT defaults (but does not yet align with the new ACR/image-build workflow). |
| docs/DeploymentGuide.md | Documents the new image build/push step and updates deployment flow/step numbering. |
| docs/CustomizingAzdParameters.md | Updates parameter docs for new defaults and image-tag meaning; removes old registry endpoint parameter. |
| .github/CODEOWNERS | Updates code owner usernames. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Abdul-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Comment on lines
+4
to
+15
| # --------------------------------------------------------------------------- | ||
| # Post-provision hook | ||
| # | ||
| # Builds the backend and frontend container images remotely inside the | ||
| # deployment's Azure Container Registry (ACR) using 'az acr build' (no local | ||
| # Docker required) and then updates the container apps to run the freshly | ||
| # built images. | ||
| # | ||
| # The required values are provided by azd as environment variables (they are | ||
| # outputs of infra/main.bicep). When the script is run outside of an azd hook | ||
| # the values are read back with 'azd env get-value'. | ||
| # --------------------------------------------------------------------------- |
Comment on lines
+4
to
+15
| # --------------------------------------------------------------------------- | ||
| # Post-provision hook (PowerShell) | ||
| # | ||
| # Builds the backend and frontend container images remotely inside the | ||
| # deployment's Azure Container Registry (ACR) using 'az acr build' (no local | ||
| # Docker required) and then updates the container apps to run the freshly | ||
| # built images. | ||
| # | ||
| # The required values are provided by azd as environment variables (they are | ||
| # outputs of infra/main.bicep). When the script is run outside of an azd hook | ||
| # the values are read back with 'azd env get-value'. | ||
| # --------------------------------------------------------------------------- |
| 4. **Resource group** selection (create new or use existing) | ||
|
|
||
| **Expected Duration:** 6-9 minutes for default configuration | ||
| **Expected Duration:** 9-14 minutes for default configuration (includes remotely building and pushing the container images) |
Comment on lines
+303
to
+307
| - For PowerShell (Windows): | ||
|
|
||
| ``` | ||
| .\scripts\build_and_push_images.ps1 | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
gpt-5.1and refines several deployment parameters and documentation to reflect these changes. The most important changes are grouped below:Container Image Build and Deployment Automation
build_and_push_images.shandbuild_and_push_images.ps1) to build backend and frontend images remotely in the deployment's ACR and update the container apps to use these images, eliminating the need for local Docker.infra/main.bicepto provision a dedicated Azure Container Registry per deployment, configure container apps to use a placeholder image initially, and output relevant ACR and container app information for use by the post-provision scripts. [1] [2] [3] [4] [5]Deployment and Documentation Updates
docs/DeploymentGuide.md) to include a new step for building and pushing container images, adjusted the expected deployment duration, and clarified the post-deployment workflow. [1] [2]docs/CustomizingAzdParameters.mdto reflect the new image build process and updated descriptions for image and model parameters.Model Version and Parameter Updates
gpt-4otogpt-5.1and updated the default version to2025-11-13in all relevant Bicep files and documentation. [1] [2] [3] [4] [5]Minor and Maintenance Changes
These changes together streamline the deployment pipeline, ensure each deployment uses its own secure and isolated container registry, and update the project to use the latest available GPT model.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information