MAINT: Consolidate regex-based scorers under regex/ #2065
Open
rlundeen2 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consolidates all regex-based true/false scorers under
pyrit/score/true_false/regex/. Several scorers (the Anthrax/Fentanyl/Meth/NerveAgent keyword scorers andStaticPromptInjectionScorer) already subclassedRegexScorerbut lived a directory up, so they've been moved into theregex/package alongside the existingRegexScorer,CredentialLeakScorer, and the OWASP LLM02 insecure-output scorers. The moves usegit mvto preserve history, and since these files already referencedRegexScorervia absolute imports, their contents are unchanged. The corresponding test files were moved intotests/unit/score/regex/to match. Public class names are re-exported frompyrit.scoreexactly as before, so no downstream imports, docs, or scenarios break.Additionally,
MarkdownInjectionScorerwas migrated from a hand-rolledre.findallTrueFalseScorerinto a properRegexScorersubclass with named default patterns for inline () and reference-style (![alt][ref]) markdown image syntax, tagged with thesecuritycategory. No deprecations were added, per the request. TheSubStringScorerandDecodingScorerwere intentionally left in place since they useTextMatchingrather than regex. The fulltests/unit/score/suite (1215 passed, 16 skipped) plusruffandtychecks all pass.