[Do not review] Update build configuration for e2e tests#40887
Draft
AmelBawa-msft wants to merge 1 commit into
Draft
[Do not review] Update build configuration for e2e tests#40887AmelBawa-msft wants to merge 1 commit into
AmelBawa-msft wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows wslc end-to-end (e2e) test build configuration to optionally use CMake unity builds for faster recompiles, and enables that mode in the CI build pipeline.
Changes:
- Add
WSL_E2E_UNITY_BUILD+ batching logic to unity-build only thetest/windows/wslc/e2e/*.cppsources viaUNITY_BUILD_MODE GROUP. - Enable
-DWSL_E2E_UNITY_BUILD=ONin.pipelines/build-job.ymlso CI uses unity builds for these e2e sources.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/windows/wslc/CMakeLists.txt | Introduces an opt-in unity build mode for wslc e2e test sources, grouping them into unity batches. |
| .pipelines/build-job.yml | Enables the new WSL_E2E_UNITY_BUILD option in CI by passing it to the CMake configure step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed