chore: dev to main PR#895
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
chore: Update azure.yaml file to show github isue URL before provisioning
fix: down merge from main, fix DCR location
chore: main to dev downmerge
Ragini-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
aniaroramsft,
malrose07,
nchandhi and
toherman-msft
as code owners
July 17, 2026 05:18
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the infrastructure templates to better support deployments that reuse an existing Log Analytics workspace, ensuring dependent resources (notably the Jumpbox DCR) align with the workspace’s scope and location. It also adds a pre-provision hook intended to provide deployment guidance before provisioning begins.
Changes:
- Added parsing +
existingresource references for an externally-provided Log Analytics workspace ID ininfra/main.bicepandinfra/main_custom.bicep, and used the workspace location for the Jumpbox DCR deployment. - Updated the generated ARM template (
infra/main.json) to include the corresponding variables/resources, updated dependencies, and refreshed generator metadata/hashes. - Added an
azdpreprovisionhook inazure.yamlto print troubleshooting guidance (Windows only as currently implemented).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| infra/main.bicep | Parse existing workspace ID, model it as an existing resource, and use workspace location for Jumpbox DCR. |
| infra/main_custom.bicep | Same existing-workspace parsing/resource modeling and DCR location alignment for the custom template. |
| infra/main.json | Regenerated ARM template output to reflect existing-workspace support and updated DCR location/dependencies. |
| azure.yaml | Added a preprovision hook to display deployment guidance prior to provisioning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
fix: Add posix in pre-deployment hook in azure.yaml
Avijit-Microsoft
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request improves support for using an existing Log Analytics workspace in the deployment process. The main changes ensure that when an existing workspace is specified, its subscription, resource group, and location are correctly referenced throughout the Bicep modules and ARM templates. Additionally, a pre-provision hook was added to the Azure deployment workflow to provide deployment guidance to users.
Improvements for existing Log Analytics workspace support:
infra/main.bicepandinfra/main_custom.bicepto extract the subscription ID, resource group, and workspace name from the providedexistingLogAnalyticsWorkspaceId, and to reference the existing workspace as a resource. The location for dependent resources (e.g., DCR) is now set to match the workspace's location. [1] [2]jumpboxDcrmodule to use the Log Analytics workspace location instead of the solution location, ensuring compliance with Azure requirements. [1] [2]infra/main.jsonto include new variables and resources for handling an existing Log Analytics workspace, and to ensure dependent resources use the correct location and dependencies. [1] [2] [3] [4]DevOps workflow enhancements:
preprovisionhook toazure.yamlthat displays helpful information and a GitHub issues link to users before provisioning, improving troubleshooting and user experience.Template and metadata updates:
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation