Skip to content

chore: dev to main PR#895

Merged
Avijit-Microsoft merged 16 commits into
mainfrom
dev
Jul 20, 2026
Merged

chore: dev to main PR#895
Avijit-Microsoft merged 16 commits into
mainfrom
dev

Conversation

@Ragini-Microsoft

Copy link
Copy Markdown
Collaborator

Purpose

This pull request improves support for using an existing Log Analytics workspace in the deployment process. The main changes ensure that when an existing workspace is specified, its subscription, resource group, and location are correctly referenced throughout the Bicep modules and ARM templates. Additionally, a pre-provision hook was added to the Azure deployment workflow to provide deployment guidance to users.

Improvements for existing Log Analytics workspace support:

  • Added logic in infra/main.bicep and infra/main_custom.bicep to extract the subscription ID, resource group, and workspace name from the provided existingLogAnalyticsWorkspaceId, and to reference the existing workspace as a resource. The location for dependent resources (e.g., DCR) is now set to match the workspace's location. [1] [2]
  • Updated the location parameter for the jumpboxDcr module to use the Log Analytics workspace location instead of the solution location, ensuring compliance with Azure requirements. [1] [2]
  • Updated infra/main.json to include new variables and resources for handling an existing Log Analytics workspace, and to ensure dependent resources use the correct location and dependencies. [1] [2] [3] [4]

DevOps workflow enhancements:

  • Added a preprovision hook to azure.yaml that displays helpful information and a GitHub issues link to users before provisioning, improving troubleshooting and user experience.

Template and metadata updates:

  • Updated Bicep and ARM template generator versions and template hashes to reflect the latest changes and maintain consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the infrastructure templates to better support deployments that reuse an existing Log Analytics workspace, ensuring dependent resources (notably the Jumpbox DCR) align with the workspace’s scope and location. It also adds a pre-provision hook intended to provide deployment guidance before provisioning begins.

Changes:

  • Added parsing + existing resource references for an externally-provided Log Analytics workspace ID in infra/main.bicep and infra/main_custom.bicep, and used the workspace location for the Jumpbox DCR deployment.
  • Updated the generated ARM template (infra/main.json) to include the corresponding variables/resources, updated dependencies, and refreshed generator metadata/hashes.
  • Added an azd preprovision hook in azure.yaml to print troubleshooting guidance (Windows only as currently implemented).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
infra/main.bicep Parse existing workspace ID, model it as an existing resource, and use workspace location for Jumpbox DCR.
infra/main_custom.bicep Same existing-workspace parsing/resource modeling and DCR location alignment for the custom template.
infra/main.json Regenerated ARM template output to reflect existing-workspace support and updated DCR location/dependencies.
azure.yaml Added a preprovision hook to display deployment guidance prior to provisioning.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/main.bicep
Comment thread infra/main_custom.bicep
Comment thread azure.yaml
NirajC3-Microsoft and others added 3 commits July 17, 2026 13:16
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 17, 2026 09:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

NirajC3-Microsoft and others added 2 commits July 19, 2026 08:50
fix: Add posix in pre-deployment hook in azure.yaml
Copilot AI review requested due to automatic review settings July 19, 2026 03:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@Avijit-Microsoft
Avijit-Microsoft merged commit 4ec8fa6 into main Jul 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants