Skip to content

chore: Main to Dev downMerge#653

Merged
Avijit-Microsoft merged 21 commits into
devfrom
main
Jul 14, 2026
Merged

chore: Main to Dev downMerge#653
Avijit-Microsoft merged 21 commits into
devfrom
main

Conversation

@Vamshi-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request introduces several infrastructure changes to how container images are configured and deployed, as well as updates to documentation and code ownership. The main focus is on removing parameterized container image settings in favor of hardcoded sample images, updating container registry access, and improving deployment instructions.

Infrastructure changes:

  • The Bicep and ARM templates (infra/main.bicep, infra/main.json) now use the public Microsoft "helloworld" container image (mcr.microsoft.com/azuredocs/containerapps-helloworld:latest) for all container apps, replacing the previous use of parameters for custom registry endpoints and image tags. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Container registry access is now explicitly set in the deployment modules, referencing the output of the container registry and its reader identity, instead of being null. This clarifies which registry is used and how identities are assigned. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Parameters for containerRegistryEndpoint and imageTag have been removed from the templates, simplifying the deployment configuration. [1] [2]
  • Role assignment for the managed identity as "Owner" has been removed from the AI Services module, likely to reduce unnecessary permissions. [1] [2]

Documentation and configuration:

  • The deployment guide (docs/DeploymentGuide.md) now instructs users to manually run ACR build/push and post-deployment scripts, reflecting the changes in automation.
  • The azure.yaml postprovision hook is now empty, indicating that post-provisioning steps are no longer automated via this hook.
  • The .github/CODEOWNERS file has been updated to correct some owner usernames.

These changes collectively shift the deployment process toward using sample images and manual post-deployment steps, while clarifying registry access and permissions.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the deployment/infrastructure posture to deploy Container Apps with a fixed public “hello world” image by default (removing prior image parameterization), tightens/clarifies registry wiring and role assignments, and shifts post-provision steps from automated azd hooks to manual scripts with updated documentation.

Changes:

  • Hardcode Container Apps images to mcr.microsoft.com/azuredocs/containerapps-helloworld:latest and remove containerRegistryEndpoint / imageTag parameters from Bicep/ARM + parameter files.
  • Add new ACR build/push helper scripts (bash + PowerShell) to build images in ACR and update Container Apps to use them post-deploy.
  • Remove azd postprovision automation and update deployment instructions and CODEOWNERS.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
infra/scripts/acr_build_push.sh Adds bash script to ACR-build images and update Container Apps post-deploy.
infra/scripts/acr_build_push.ps1 Adds PowerShell equivalent of the ACR build/push + app update flow.
infra/modules/container-registry.bicep Adjusts default publicNetworkAccess behavior based on private networking toggle.
infra/main.waf.parameters.json Removes registry/image parameter entries from WAF parameters file.
infra/main.parameters.json Removes registry/image parameter entries from default parameters file.
infra/main.json Removes containerRegistryEndpoint / imageTag parameters; hardcodes hello world images; updates registry identity wiring.
infra/main.bicep Removes containerRegistryEndpoint / imageTag parameters; hardcodes hello world images; updates registry identity wiring.
infra/main_custom.bicep Removes containerRegistryEndpoint / imageTag parameters (custom template flavor).
docs/DeploymentGuide.md Updates post-deployment instructions to run ACR build/push and post-deploy scripts manually.
azure.yaml Clears postprovision hook (no longer auto-running post-deploy steps).
.github/CODEOWNERS Updates listed default code owners.
Comments suppressed due to low confidence (2)

infra/main.json:114

  • infra/main.json no longer defines the imageTag parameter, but the repo's CI workflow still passes imageTag=... to az deployment group create (see .github/workflows/deploy.yml:159). That deployment will fail with an unrecognized/unused parameter error unless the workflow is updated (or the parameter is reintroduced).
    docs/DeploymentGuide.md:339
  • This section still says schema registration happens automatically via the azd up postprovision hook, but azure.yaml now sets hooks.postprovision to {} and Step 5.1 instructs running post_deployment.* manually. The current text is contradictory and will mislead users following the guide.
### 5.2 Schema Registration (Automatic)

 > Want to customize the schemas for your own documents? [Learn more about adding your own schemas here.](./CustomizeSchemaData.md)

Schema registration happens **automatically** as part of the `azd up` post-provisioning hook — no manual steps required. After infrastructure is deployed, the hook:


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/scripts/acr_build_push.ps1
Comment thread infra/scripts/acr_build_push.ps1
Comment thread infra/scripts/acr_build_push.sh
@Vamshi-Microsoft Vamshi-Microsoft changed the title chore: Dev to Main Merge chore: Main to Dev downMerge Jul 14, 2026
@Avijit-Microsoft Avijit-Microsoft merged commit 796d3a0 into dev Jul 14, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants