fix(redirection): ignore repeated Shift keydown for next-version shortcut#2082
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix bug with Playwright docs redirecting to unreleased version
fix(redirection): ignore repeated Shift keydown for next-version shortcut
Jul 1, 2026
Skn0tt
reviewed
Jul 1, 2026
| let keyPressState = 0; | ||
| document.addEventListener('keydown', (e) => { | ||
| if (e.repeat) { | ||
| keyPressState = 0; |
Member
There was a problem hiding this comment.
@copilot let's just rearly-return or include this in the condition below. no need to reset, this can actively harm 5-tap.
Contributor
Author
There was a problem hiding this comment.
Done — now just early-returns on e.repeat without touching keyPressState, in 6c2... (latest commit).
Contributor
Author
There was a problem hiding this comment.
(correction on hash) addressed in 2257997.
Member
|
@copilot address the feedback |
Skn0tt
approved these changes
Jul 1, 2026
Contributor
Author
dgozman
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hidden "press Shift five times to jump to the unreleased (
/docs/next/) docs" shortcut fired unintentionally. Holding Shift while moving the mouse or scrolling horizontally emits auto-repeatkeydownevents (e.repeat === true), each counted as a press, so the count reached 5 and navigated away — reproducible on Windows and Mac in Chrome.Changes
e.repeatin thekeydownhandler instatic/js/redirection.js: auto-repeat events now reset the counter and return early, so only five distinct Shift presses trigger the shortcut.