Bug bash fixes: Msgextension cardbutton clicked, onsetting added, activity preview fix, SSO status reconciliation - #630
Merged
Merged
Conversation
- StreamingBot/ObservabilityBot: migrate to AzureOpenAI__ config format - ObservabilityBot: wire ConnectionStrings__AppInsights for App Insights - ObservabilityBot: inject IConfiguration for deployment name lookup - OAuthFlowBot: print token statuses as indented JSON - UserTokenClient: print GetTokenStatus response as indented JSON - Context.GetConnectionStatusAsync: reconcile GetTokenStatus results with GetTokenAsync per-connection to fix SSO showing as not connected Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ba86bba6-7d8e-4502-81fd-45e0e9ea6617
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Bug-bash updates across core SDK and sample bots to align configuration with AzureOpenAI__* conventions, improve ObservabilityBot telemetry wiring, and fix OAuth/SSO connection status reporting.
Changes:
- Updated sample configuration/docs to use
AzureOpenAI__{Endpoint,ApiKey,Deployment}(andConnectionStrings__AppInsights) instead of legacy env var names. - Enhanced
Context.GetConnectionStatusAsyncto reconcileGetTokenStatusresults with per-connectionGetTokenAsyncto address silent SSO status mismatches. - Simplified token status array construction in
UserTokenClient.GetTokenStatusAsyncusing collection expressions.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/Microsoft.Teams.Core/UserTokenClient.cs | Simplifies GetTokenStatusAsync return construction using collection expressions. |
| core/src/Microsoft.Teams.Apps/Context.cs | Reconciles token status with per-connection token retrieval to improve SSO status accuracy. |
| core/samples/StreamingBot/README.md | Updates sample setup docs to the AzureOpenAI__* config format. |
| core/samples/StreamingBot/Properties/launchSettings.TEMPLATE.json | Removes legacy AZURE_OPENAI_* env vars from the template. |
| core/samples/StreamingBot/Program.cs | Reads Azure OpenAI settings from AzureOpenAI:* configuration keys. |
| core/samples/ObservabilityBot/README.md | Updates prerequisites/export-target docs and config key names. |
| core/samples/ObservabilityBot/Properties/launchSettings.TEMPLATE.json | Switches App Insights and Azure OpenAI settings to config-style keys. |
| core/samples/ObservabilityBot/Program.cs | Wires Azure Monitor exporter connection string via ConnectionStrings:AppInsights and updates Azure OpenAI config reads. |
| core/samples/ObservabilityBot/ObservabilityBotApp.cs | Uses injected IConfiguration to fetch deployment name (instead of env var). |
| core/samples/GraphBot/README.md | Removes local config section from the GraphBot sample docs. |
| core/samples/ExtAIBot/README.md | Updates Azure OpenAI configuration documentation formatting/keys. |
| core/samples/CustomHosting/README.md | Minor README formatting tweak. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
singhk97
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements and new features to the
MessageExtensionBotsample, streamlines configuration for several other samples, and enhances code maintainability and clarity. The most notable changes include the addition of a working message extension settings flow (with UI and manifest updates), improved adaptive card actions, and the migration of sensitive configuration from environment variables toappsettingsfor better local development experience.Message Extension Settings & Actions
wwwroot/settings.html) for message extension configuration, with Teams SDK integration for saving/cancelling settings.OnQuerySettingUrlandOnSettinghandlers inProgram.csto support opening and saving extension settings, including proper manifest and domain configuration. [1] [2] [3] [4] [5]canUpdateConfigurationplacement and requiredvalidDomainsfor settings. (F2f34638L2R2, [1] [2]Adaptive Card and Action Improvements
OpenUrlAction) to adaptive cards inCreateSelectItemCard, and handled card button clicks in the bot with the newOnCardButtonClickedhandler. [1] [2]Configuration and Environment Variable Migration
appsettings/launch settings forObservabilityBot,ExtAIBot, andMcpServersamples, and updated documentation accordingly. [1] [2] [3] [4] [5] [6] [7] [8]Codebase and Documentation Cleanup
Other Enhancements
These changes collectively make the samples more robust, easier to configure, and better aligned with Teams extensibility best practices.