Correct AgenticIdentity helper and scoped API naming - #536
Open
heyitsaamir wants to merge 4 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a43ae3bd-97f9-4dbb-bfd0-ffc3dce0a3b7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a43ae3bd-97f9-4dbb-bfd0-ffc3dce0a3b7
This reverts commit c3092c9. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a43ae3bd-97f9-4dbb-bfd0-ffc3dce0a3b7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a43ae3bd-97f9-4dbb-bfd0-ffc3dce0a3b7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follow-up corrects the Agent365 Python API shape after #533:
App.get_agentic_identity(...)remains the app-level convenience for filling blueprint and tenant context, while the lower-level API client keeps one scoped identity method. The result preserves the useful app helper and avoids two equivalent scoped client names.Decisions
App.get_agentic_identity(...)is useful because the app already owns the configured blueprint/client ID and tenant ID; the API client does not need bothfrom_andfor_names for the same scope operation.agentic_app_idnullable so callers can constructAgenticIdentityfor agentic app or agentic user flows without implying that every scope is user-backed.Validation
The echo sample starts successfully in this branch;
/returns the existing 404 response because the sample does not expose a root route.