Add importProperties parameter for selective property import and improve state tracking #90
Open
RudyBricks wants to merge 7 commits into
Open
Add importProperties parameter for selective property import and improve state tracking #90RudyBricks wants to merge 7 commits into
importProperties parameter for selective property import and improve state tracking #90RudyBricks wants to merge 7 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
importProperties parameter for selective property import and improve state tracking
Resolved conflicts by combining import examples from both branches: - Kept beta API version example from main - Kept importProperties examples from fix-89-import-drift branch
importProperties parameter for selective property import and improve state trackingimportProperties parameter for selective property import and improve state tracking
importProperties parameter for selective property import and improve state tracking importProperties parameter for selective property import and improve state tracking
Author
|
@ms-henglu anything I can do to make the review easier for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR enhances the import functionality for
msgraph_resourceto support importing existing Microsoft Graph resources without triggering unintended modifications (see #89). It introduces theimportPropertiesquery parameter and improves state management for more accurate drift detection.Changes
1. Import with Selective Properties (
importProperties)importPropertiesquery parameter in import operations/groups/{id}?importProperties=displayName,mailEnabled,mailNickname,securityEnablednullin Terraform state during importweb.redirectUris)2. Enhanced State Management
3. Comprehensive Documentation
docs/resources/resource.mdwith detailed import examplesdocs/resources/groups.mdwith group-specific import patternsdocs/guides/importing_resources.mdexamples/imports/groups/Use Case
This is particularly valuable when importing existing Microsoft Graph resources into Terraform management:
Before: Importing a resource would result in an empty body, causing Terraform to want to remove all properties on the next plan.
After: Users can selectively import properties they want to manage:
terraform import msgraph_resource.group "/groups/{id}?importProperties=displayName,mailEnabled,mailNickname,securityEnabled"