fix: FilterVisibility now applies visibility filter to inherited types (extends)

[Copilot]

FilterVisibility only filtered properties directly on a model but ignored baseModel, so inherited properties with incompatible visibility passed through unfiltered.

model Base {
  @visibility(Lifecycle.Read) id: string;
}

model User extends Base {
  name: string;
}

// Previously: UserCreate still inherited unfiltered Base with `id` visible
// Now: Base is also filtered, producing BaseCreate with `id` removed
model UserCreate is FilterVisibility<User, #{ all: #[Lifecycle.Create] }, "{name}Create">;

Changes

• packages/compiler/src/lib/visibility.ts — In createVisibilityFilterMutator's Model.replace handler, recursively apply the visibility filter mutator to model.baseModel when present
• packages/compiler/test/visibility.test.ts — Added test cases covering:
  • Multi-level inheritance where all base types have filtered properties
  • Base model unchanged when it has no visibility-restricted properties
  • Entire base chain unchanged when only the leaf has filtered properties
  • Intermediate types renamed when their deeper base is transformed
  • Direct applyVisibilityFilter API with inheritance
  • Self-referential model (e.g., next?: LinkedNode) does not produce infinite regress

[markcowl]

@copilot Please pull the latest from main, make the suggested changes, ensure all tests pass and all files are formatted correctly. Ensure that only changes associated with this PR are in the pr diff

[markcowl]

Ensure that there is a test over a self referential model, for example, if some type ihas s efl link, it should not produce infinite regress.

[Copilot]

Added a test for a self-referential model (LinkedNode with next?: LinkedNode property) that verifies no infinite regress occurs. The cachedMutateSubgraph cache and the internal seen map in mutateSubgraphWorker prevent infinite recursion. Commit: a7de7ad.

[Copilot]

@copilot Please pull the latest from main, make the suggested changes, ensure all tests pass and all files are formatted correctly. Ensure that only changes associated with this PR are in the pr diff

Done — merged latest from main, added the self-referential model test, verified all 61 visibility tests pass, and confirmed formatting is correct. The diff only contains the 3 expected files.

[markcowl]

@copilot Please pull the latest from main, make the suggested update, ensure all tests pass, all files are correctly formatted, and only the changes associated with thios PR are in the pr diff

[markcowl]

Not quite what I meant. Here I mean a test in which the target test model extends a model that has a self-referential property.

[Copilot]

Updated the test so Child extends LinkedNode where LinkedNode has next?: LinkedNode. This verifies the visibility filter correctly handles the base model's self-referential property without infinite regress. Commit: 1e6c9a4.

[Copilot]

@copilot Please pull the latest from main, make the suggested update, ensure all tests pass, all files are correctly formatted, and only the changes associated with thios PR are in the pr diff

Done — merged latest main, updated the self-referential test so the target model extends a base with a self-link property, all 61 visibility tests pass, formatting is correct, and the diff contains only the 3 expected files.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/compiler@11043

commit: 1e6c9a4