Skip to content

fix: file-found Badge vertical - #273098

Open
ohah wants to merge 4 commits into
microsoft:mainfrom
ohah:fix/235159-2
Open

fix: file-found Badge vertical#273098
ohah wants to merge 4 commits into
microsoft:mainfrom
ohah:fix/235159-2

Conversation

@ohah

@ohah ohah commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

Fixed #235159

This caused a regression in #273052, so I've fixed the specific line to avoid side effects.

Fixes #235159
Addresses #273052

FIXED ScreenShot

스크린샷 2025-10-24 오후 9 10 19 스크린샷 2025-10-24 오후 9 13 10

Copilot AI review requested due to automatic review settings October 24, 2025 12:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a vertical alignment issue with the file-found badge in the Explorer view by applying a small upward translation. The fix addresses issue #235159 while being careful not to reintroduce regression #273052.

Key Changes:

  • Applied a specific vertical translation to the count badge when displayed in collapsed folder rows in the Explorer view

@vs-code-engineering

vs-code-engineering Bot commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/contrib/files/browser/media/explorerviewlet.css

Comment thread src/vs/workbench/contrib/files/browser/media/explorerviewlet.css Outdated
@benibenj
benibenj enabled auto-merge (squash) October 27, 2025 09:09
benibenj
benibenj previously approved these changes Oct 27, 2025
@vs-code-engineering vs-code-engineering Bot added this to the October 2025 milestone Oct 27, 2025
Tyriar
Tyriar previously requested changes Oct 27, 2025
Comment thread src/vs/workbench/contrib/files/browser/media/explorerviewlet.css Outdated
@benibenj benibenj modified the milestones: October 2025, November 2025 Nov 2, 2025
@Eplankton

Copy link
Copy Markdown

In current release version of vscode, a very strange align mess-up occurs in all positions, like these:
图片

@dmitrivMS
dmitrivMS marked this pull request as draft July 29, 2026 07:38
auto-merge was automatically disabled July 29, 2026 07:38

Pull request was converted to draft

@dmitrivMS
dmitrivMS marked this pull request as ready for review July 29, 2026 07:47
@dmitrivMS
dmitrivMS enabled auto-merge (squash) July 29, 2026 07:47
@ohah

ohah commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@dmitrivMS thx

@alexr00
alexr00 disabled auto-merge July 29, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Number-of-files-found Badge is not at the center of the list item vertically

8 participants