Use generic cachi2 artifact paths in konflux.Dockerfile#15
Merged
Conversation
Align main with release-0.9 / mta-8.1: ocp-build-data artifact lockfile entries use stable filenames (jdtls-product.tar.gz, fernflower.jar, etc.) so version bumps only require lockfile URL changes, not Dockerfile cp paths. rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated konflux.Dockerfile to reference generic artifact filenames (fernflower.jar, java-analyzer-bundle.core.jar, maven-index-data.zip, jdtls-product.tar.gz) copied from cachi2 output paths, replacing previous version-specific filenames. Unpacking and copy logic remains unchanged. ChangesGeneric Artifact Filename Update
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
konflux.Dockerfileto copy cachi2 artifacts using stable generic filenames, matching the existingrelease-0.9/ MTA 8.1 patternfilenamefield and Dockerfilecppaths stay constantMotivation
maincurrently hard-codes versioned cachi2 paths (e.g.jdt-language-server-1.51.0-...tar.gz), so every JDTLS or Maven coord bump requires a Dockerfile change. The 1.51.0 Eclipse milestone was also removed, breaking prefetch/rebase.MTA 8.1 already uses generic lockfile filenames (ocp-build-data mta-8.1) and generic
cppaths on release-0.9. MTA 8.2 ocp-build-data is aligned in openshift-eng/ocp-build-data#11596.Changes
fernflower-8.1.0.GA-redhat-00001.jarfernflower.jarjava-analyzer-bundle.core-8.1.0.CR1-redhat-00003.jarjava-analyzer-bundle.core.jarmaven-index-data-v20251112021242.zipmaven-index-data.zipjdt-language-server-1.51.0-202510022025.tar.gzjdtls-product.tar.gzTest plan
mta-jdtls-server-base,mta-java-external-provider,mta-cliSummary by CodeRabbit