Skip to content

Use generic cachi2 artifact paths in konflux.Dockerfile#15

Merged
fbladilo merged 1 commit into
migtools:mainfrom
fbladilo:fix_branch
Jul 1, 2026
Merged

Use generic cachi2 artifact paths in konflux.Dockerfile#15
fbladilo merged 1 commit into
migtools:mainfrom
fbladilo:fix_branch

Conversation

@fbladilo

@fbladilo fbladilo commented Jul 1, 2026

Copy link
Copy Markdown

Summary

  • Update konflux.Dockerfile to copy cachi2 artifacts using stable generic filenames, matching the existing release-0.9 / MTA 8.1 pattern
  • Version-specific URLs remain in ocp-build-data artifact lockfile entries; only the lockfile filename field and Dockerfile cp paths stay constant

Motivation

main currently hard-codes versioned cachi2 paths (e.g. jdt-language-server-1.51.0-...tar.gz), so every JDTLS or Maven coord bump requires a Dockerfile change. The 1.51.0 Eclipse milestone was also removed, breaking prefetch/rebase.

MTA 8.1 already uses generic lockfile filenames (ocp-build-data mta-8.1) and generic cp paths on release-0.9. MTA 8.2 ocp-build-data is aligned in openshift-eng/ocp-build-data#11596.

Changes

cachi2 path (before) cachi2 path (after)
fernflower-8.1.0.GA-redhat-00001.jar fernflower.jar
java-analyzer-bundle.core-8.1.0.CR1-redhat-00003.jar java-analyzer-bundle.core.jar
maven-index-data-v20251112021242.zip maven-index-data.zip
jdt-language-server-1.51.0-202510022025.tar.gz jdtls-product.tar.gz

Test plan

  • Merge with ocp-build-data mta-8.2 artifact lockfile generic filenames
  • Jenkins layered-products rebuild: mta-jdtls-server-base, mta-java-external-provider, mta-cli

Summary by CodeRabbit

  • Bug Fixes
    • Updated the build to use standardized artifact names during packaging, helping ensure the correct files are picked up reliably.
    • Kept the existing extraction and placement behavior intact while aligning it with the newer artifact naming format.

Align main with release-0.9 / mta-8.1: ocp-build-data artifact lockfile
entries use stable filenames (jdtls-product.tar.gz, fernflower.jar, etc.) so
version bumps only require lockfile URL changes, not Dockerfile cp paths.

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9443cdb1-0306-42a8-940f-55cc6b85b055

📥 Commits

Reviewing files that changed from the base of the PR and between b964755 and 97fff97.

📒 Files selected for processing (1)
  • konflux.Dockerfile

📝 Walkthrough

Walkthrough

Updated konflux.Dockerfile to reference generic artifact filenames (fernflower.jar, java-analyzer-bundle.core.jar, maven-index-data.zip, jdtls-product.tar.gz) copied from cachi2 output paths, replacing previous version-specific filenames. Unpacking and copy logic remains unchanged.

Changes

Generic Artifact Filename Update

Layer / File(s) Summary
Generic filename substitution for build artifacts
konflux.Dockerfile
Source filenames for fernflower, java-analyzer-bundle, maven-index-data, and jdtls artifacts are updated to generic names copied from the cachi2 generic output paths, with existing unpack/copy flows unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: switching konflux.Dockerfile to generic cachi2 artifact paths.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fbladilo fbladilo merged commit 7d84179 into migtools:main Jul 1, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant