feat: opaque token and payment hash fix#1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Minmo BTCPay Server plugin to use a single opaque connection token (instead of separate team/wallet IDs plus API token) and adjusts invoice handling to better normalize payment hashes and descriptions when communicating with the Minmo wallet facade.
Changes:
- Switch connection string format to
type=minmo;server=...;token=...and update help/README examples accordingly. - Update Minmo client request routing and bearer auth to use the opaque token and simplified
/v1/btcpay/wallet/{operation}endpoint. - Add normalization for invoice description and payment hash parsing (including deriving payment hash from BOLT11 when needed).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| btcpayserver/Minmo.BTCPayServer.Plugin/Views/MinmoLightningNodeHelp.cshtml | Updates UI help text to show the new token-based connection string. |
| btcpayserver/Minmo.BTCPayServer.Plugin/README.md | Updates documentation to describe the opaque connection token and new connection string format. |
| btcpayserver/Minmo.BTCPayServer.Plugin/MinmoLightningConnectionString.cs | Changes parsed connection string fields to a single Token value. |
| btcpayserver/Minmo.BTCPayServer.Plugin/MinmoLightningClient.cs | Uses the new token-based auth/routing and adds payment-hash/description normalization in invoice handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+267
to
+282
| private string? NormalizePaymentHash(string? paymentHash, string? bolt11) | ||
| { | ||
| if (!string.IsNullOrWhiteSpace(paymentHash) && | ||
| uint256.TryParse(paymentHash, out var parsedPaymentHash)) | ||
| { | ||
| return parsedPaymentHash.ToString(); | ||
| } | ||
|
|
||
| if (!string.IsNullOrWhiteSpace(bolt11) && | ||
| BOLT11PaymentRequest.TryParse(bolt11, out var paymentRequest, _network)) | ||
| { | ||
| return paymentRequest?.PaymentHash?.ToString(); | ||
| } | ||
|
|
||
| return null; | ||
| } |
Comment on lines
+303
to
+306
| catch (JsonReaderException) | ||
| { | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.