[Server] Fix completion/complete crash for plain ref/resource#388
Open
NarimanGardi wants to merge 1 commit into
Open
[Server] Fix completion/complete crash for plain ref/resource#388NarimanGardi wants to merge 1 commit into
NarimanGardi wants to merge 1 commit into
Conversation
A non-template resource resolves to a ResourceReference, which has no completionProviders property; only prompts and resource templates do. Read providers from those instead, returning an empty completion result when a resource has none.
NarimanGardi
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #387.
completion/completecrashes for aref/resourcepointing at a plain resource:getResource()returns aResourceReference, but the handler reads$reference->completionProviders, which onlyPromptReferenceandResourceTemplateReferencedeclare.Providers now come from the prompt or the matched resource template; a resource with no template yields an empty completion result. Added a handler test for both the plain-resource regression and the resource-template path.