Skip to content

fix(rasters): accommodate rasterio>=1.5#2781

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:fix-2780
Jul 11, 2026
Merged

fix(rasters): accommodate rasterio>=1.5#2781
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:fix-2780

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Jul 10, 2026

Copy link
Copy Markdown
Member

Pass adjust=False to rasterio.plot.show() unless the caller sets it True. Accommodate the default switch in rasterio/rasterio#3171. Looks like the default may be switched back rasterio/rasterio#3549, but in any case this guarantees the right behavior by default, and a caller choosing to pass adjust=True can set vmin/vmax accordingly.

Close #2780

@wpbonelli wpbonelli added this to the 3.11 milestone Jul 10, 2026
@wpbonelli wpbonelli added bug dependencies Pull requests that update a dependency file labels Jul 10, 2026
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.6%. Comparing base (556c088) to head (25e7b89).
⚠️ Report is 182 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/rasters.py 0.0% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2781      +/-   ##
===========================================
+ Coverage     55.5%    72.6%   +17.0%     
===========================================
  Files          644      677      +33     
  Lines       124135   132734    +8599     
===========================================
+ Hits         68947    96367   +27420     
+ Misses       55188    36367   -18821     
Files with missing lines Coverage Δ
flopy/utils/rasters.py 70.9% <0.0%> (-3.1%) ⬇️

... and 579 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli marked this pull request as ready for review July 10, 2026 21:24
@wpbonelli wpbonelli merged commit 38b6a10 into modflowpy:develop Jul 11, 2026
31 of 32 checks passed
@wpbonelli wpbonelli deleted the fix-2780 branch July 11, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Wrong result from flopy.utils.Raster.plot with python 3.14.6

1 participant