feat(iot): integrate Scanner Inbox, inbound Create plan, shift-close, labels, Guard Desk by mohabbis · Pull Request #328 · mohabbis/ghost

mohabbis · 2026-07-18T21:40:01Z

Summary

Single integration branch that stacks the IoT feature work into working software on top of master (design docs already merged via #321):

Build fix — disable tokenizers esaxx_fast so --features experimental compiles on Linux (fix(build): unbreak experimental feature compile (esaxx-rs) #326)
F1 — Scanner Inbox Zone preset + ready-to-file signal → Scan & Preview only (feat(organizer): Scanner Inbox preset + ready-to-file signal (F1) #323)
F2 — inbound intent list + fabric_convert_inbound_intent → read-only plan / Converted; /inbound/webhook alias (feat(inbound): batch-landed intents → Create plan (F2) #327)
F3 — pos.close taxonomy, samples, shift-close UI copy; no POS key injection (feat(inbound): pos.close shift-close intent packet (F3) #324)
F4 — post-run folder label preview/export + audit sidecar notes; no printer SDK (feat(organizer): folder label preview/export after run (F4) #325)
F5 — Guard Desk on-demand chosen-file OCR copy + DOM contract (feat(guard-desk): on-demand chosen-file OCR copy (F5) #322)
macOS CI — Enigo init timeout is Windows-only (Enigo is !Send on Darwin)

Supersedes closed individual PRs #322–#327 and #326 — merge this PR.

Trust invariants preserved: devices/webhooks propose only; Create plan never executes; no camera/mic; Guard Desk stays prototype-labeled.

Validation (this branch)

cargo fmt --check
cargo check --all-targets
cargo check --all-targets --features experimental
cargo clippy --all-targets (+ experimental) -- -D warnings
cargo test --features experimental --lib convert
cargo test --lib folder_label
cargo test --test frontend_dom_contract
ghost mcp demo smoke (plan path)

Test plan

CI green (esp. macOS Tauri smoke after Enigo fix)
Organizer: Scanner Inbox preset → drop files → banner → Scan & Preview → Approve
Experimental: MCP HTTP → POST /inbound/webhook → Create plan → Approve separately
POST pos.close sample → shift-close card
After organize: Preview folder label → export txt
Guard Desk: choose file → Run review (no camera prompt)

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

tokenizers' default esaxx_fast feature compiles esaxx-rs via clang/c++, which fails on Linux VMs where /usr/bin/c++ is clang selecting GCC 14 without libstdc++-14-dev (`cstdint` not found). Keep progressbar+onig only — local_llm only needs load/encode. Document the VM workaround. Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

vercel · 2026-07-18T21:40:07Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
ghost	Ready	Preview, Comment	Jul 18, 2026 9:51pm

cursor · 2026-07-18T21:40:07Z

Stacked integration of #326 + F1–F5. Individual feature PRs (#322–#327, #326) are superseded by this branch — merge this one when CI is green.

Validated locally: fmt, check, experimental check/clippy, convert + folder_label + frontend_dom_contract tests.

macOS Enigo holds CGEventSource (!Send), so the timeout thread that fixed Windows CI hangs fails to compile on Darwin Tauri smoke builds. Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0bb5af073

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-18T21:52:51Z

+      const intent = intentId ? pendingById.get(intentId) : null;
+      if (!intent) return;
+      const card = organizerInboundIntentCopy(intent);
+      if (!intent.zone_id) {


Verify inbound zones before creating plans

When the webhook payload is CloudEvents/Fabric item, parse_inbound_body stores the event subject as zone_id (the checked-in sample uses lakehouses/lh-001), but this new truthiness check treats any non-empty value as a real Organizer Zone and calls fabric_convert_inbound_intent. In that common case the primary “Create plan” path just fails with no zone with id ... and the UI never offers the Zone-selection flow; validate that the zone exists (or only set zone_id for Ghost-native payloads) before taking this branch.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-18T21:52:51Z

+        .map_err(|e| e.to_string())?
+        .ok_or_else(|| format!("no zone with id {zone_id}"))?;
+    let rules = list_folder_rules(&conn, &zone_id).map_err(|e| e.to_string())?;
+    let ready_files = crate::organizer::planner::scan_zone_files(&conn, &zone_id)


Count only Scanner Inbox source files

For Scanner Inbox two-folder zones, the inbox rule is the readable/non-create source while the destination rule is also readable so planning can inspect conflicts. scan_zone_files scans every can_read rule, so after filing, files already in the destination are counted as ready_files and the banner keeps prompting “Scan & Preview” even when the inbox is empty; count only the source/inbox rule set for this signal.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-18T21:52:51Z

+  const presetName =
+    presetChoice ||
+    (await ghostPick(


Ignore click events when opening guided setup

The existing toolbar wiring still passes organizerRunWizard directly to addEventListener, so clicking the normal “Guided setup” button supplies the click Event as presetChoice. Because that object is truthy, this branch skips the preset picker and looks up ORGANIZER_PRESETS[event], immediately showing “Unknown Organizer preset” instead of opening setup; wrap the handler or accept only string preset names.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-18T21:52:52Z

+        reset_store_for_tests();
+        let intent = record_intent(Some("zone-1".into()), "pos.close", "Shift closed");


Isolate inbound intent tests from shared store

These new inbound tests share the process-global STORE and the same fabric-inbound-intents.json file with each other and the command-layer conversion test, while Rust runs tests in parallel by default. One test can call reset_store_for_tests() between another test's record_intent and convert_intent/list_pending, producing intermittent empty queues or unknown-intent failures; serialize these tests or give each test an isolated store path.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-18T21:52:52Z

                "hash": stored.hash,
                "prev_hash": stored.prev_hash,
                "audit": stored.audit.masked(),
+                "label_notes": stored.label_notes,


Mask label notes in audit exports

When users export an audit after using the new label flow, these sidecar notes are written raw even though the JSON export masks the audit log itself. The note detail can include the generated label filename, which is derived from the Zone name, so a client/email-like Zone name leaks into the portable JSON/CSV/signed reports despite the existing PII-redaction contract; mask or sanitize stored.label_notes before exporting them.

Useful? React with 👍 / 👎.

cursoragent and others added 14 commits July 18, 2026 21:12

Clarify Guard Desk on-demand OCR flow

1b700c7

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

Harden inbound intent plan creation UX

e2ed694

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

Remove unrelated branch carryover

146c12a

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

feat: add scanner inbox organizer flow

449e4fb

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

feat(organizer): add preview-only folder labels

0f46661

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

feat: add shift-close inbound organizer intents

6bb0ece

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

merge: experimental esaxx build fix (#326)

dc8d200

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

merge: F1 Scanner Inbox (#323)

1883cfc

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

merge: F2 batch-landed Create plan (#327)

76bc10b

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

merge: F3 shift-close (#324)

4124dad

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

merge: F4 file-and-label (#325)

6c14375

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

merge: F5 on-demand OCR copy (#322)

db501d8

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

fix(clippy): use sort_by_key for inbound intent ordering

a0bb5af

Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

vercel Bot deployed to Preview July 18, 2026 21:40 View deployment

fix(runtime): keep Enigo init timeout Windows-only

31a16c8

macOS Enigo holds CGEventSource (!Send), so the timeout thread that fixed Windows CI hangs fails to compile on Darwin Tauri smoke builds. Co-authored-by: Muhammad Rafiq <mohabbis@users.noreply.github.com>

vercel Bot deployed to Preview July 18, 2026 21:51 View deployment

mohabbis merged commit 8dae8ae into master Jul 18, 2026
21 of 23 checks passed

chatgpt-codex-connector Bot reviewed Jul 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(iot): integrate Scanner Inbox, inbound Create plan, shift-close, labels, Guard Desk#328

feat(iot): integrate Scanner Inbox, inbound Create plan, shift-close, labels, Guard Desk#328
mohabbis merged 15 commits into
masterfrom
cursor/iot-working-integrate-e1a6

mohabbis commented Jul 18, 2026 •

edited by cursor Bot

Loading

Uh oh!

vercel Bot commented Jul 18, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Jul 18, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 18, 2026

Uh oh!

chatgpt-codex-connector Bot Jul 18, 2026

Uh oh!

chatgpt-codex-connector Bot Jul 18, 2026

Uh oh!

chatgpt-codex-connector Bot Jul 18, 2026

Uh oh!

chatgpt-codex-connector Bot Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		reset_store_for_tests();
		let intent = record_intent(Some("zone-1".into()), "pos.close", "Shift closed");

Conversation

mohabbis commented Jul 18, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation (this branch)

Test plan

Uh oh!

vercel Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 18, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mohabbis commented Jul 18, 2026 •

edited by cursor Bot

Loading

vercel Bot commented Jul 18, 2026 •

edited

Loading