test(mongodb-schema): remove timeout workaround from mongodb-schema integration test COMPASS-10911 - #847
Conversation
There was a problem hiding this comment.
🟢 Ready to approve
The change is a narrow, test-only revert that matches the stated intent and does not introduce functional code risk.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Removes a previously added Mocha timeout override in the mongodb-schema integration test suite, reverting an attempted workaround for test flakiness that did not improve stability.
Changes:
- Removed the
this.timeout(30_000)override from the “With a MongoDB Cluster” integration test suite, falling back to the repo’s standard Mocha timeout configuration.
File summaries
| File | Description |
|---|---|
| packages/mongodb-schema/test/integration/generate-and-validate.test.ts | Removes the suite-level Mocha timeout workaround from the MongoDB cluster integration tests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
|
Is it a correct Jira ticket in the title? Maybe the description should be more detailed to understand how those are related. |
This is all part of the js-yaml bump for compass. It's been a side quest 😅 |
Description
Revert attempt to workaround flaky test as it didn't help.
When we moved mongodb-schema to this monorepo, as part of js-yaml migration for compass, the integration tests started to fail in a non-consistent way. Another ticket was open to investigate the issue later on.
Open Questions
Checklist