Skip to content

chore: drop stale zkTrie comment + flip sample genesis useZktrie=false#1000

Open
curryxbo wants to merge 3 commits into
mainfrom
chore/zktrie-cleanup
Open

chore: drop stale zkTrie comment + flip sample genesis useZktrie=false#1000
curryxbo wants to merge 3 commits into
mainfrom
chore/zktrie-cleanup

Conversation

@curryxbo

@curryxbo curryxbo commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Legacy zkTrie cleanup (monorepo side), companion to the go-ethereum zkTrie cleanup.

Scope

  • node/core/executor.go: drop a stale snap-sync zkTrie comment.
  • node/ops-morph/genesis-l2.json, genesis_geth.json: flip stale sample useZktrie:true to false (production genesis is already false).

Build

go build ./... in node/ passes.

Context

The indirect dependency scroll-tech/zktrie will drop out via go mod tidy once the upstream go-ethereum cleanup lands.
Design doc: https://larkfive.sg.larksuite.com/wiki/Qan7w367ji6qn1kU2XTlPzOagte

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Updated network configuration defaults so the relevant trie mode is now disabled in genesis settings.
    • Clarified sync-related messaging in documentation comments to better reflect current behavior.

Part of PR-A (zkTrie state cleanup + post-Jade trusted-prefix). MPT is the
confirmed terminal state; pre-Jade history is a trusted prefix.

Changes:
- node/core/executor.go: drop stale "until Geth enables snapshot with zkTrie"
  reference in the full-sync comment.
- node/ops-morph/genesis-l2.json, genesis_geth.json: set scroll.useZktrie
  false (MPT terminal state).

NOT touched (deliberate): go.mod indirect go-ethereum dependency — must wait
for the go-ethereum PR-A to merge before bumping; running `go mod tidy` now
would pull it back. Submodule pointer left as-is.

go build ./... passes in node/. Draft PR-A. Do not push.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cf286262-7262-4816-9b5c-882d8dfe541e

📥 Commits

Reviewing files that changed from the base of the PR and between c2c67aa and 87c5e74.

📒 Files selected for processing (3)
  • node/core/executor.go
  • node/ops-morph/genesis-l2.json
  • node/ops-morph/genesis_geth.json

📝 Walkthrough

Walkthrough

This PR disables zkTrie by setting useZktrie to false in two genesis configuration files (genesis-l2.json and genesis_geth.json) and updates an inline comment in executor.go describing snap sync behavior, without altering any executable logic.

Changes

zkTrie Disablement

Layer / File(s) Summary
Genesis config zkTrie toggle
node/ops-morph/genesis-l2.json, node/ops-morph/genesis_geth.json
The scroll.useZktrie setting is changed from true to false in both genesis configuration files.
Executor comment update
node/core/executor.go
The comment explaining why snap sync is disabled is shortened, removing the reference to Geth enabling snapshot with zkTrie; no logic changes.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Estimated code review effort

1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: removing the stale zkTrie comment and flipping sample genesis useZktrie to false.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/zktrie-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@curryxbo curryxbo marked this pull request as ready for review July 2, 2026 06:40
@curryxbo curryxbo requested a review from a team as a code owner July 2, 2026 06:40
@curryxbo curryxbo requested review from r3aker86 and removed request for a team July 2, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant