Skip to content

Bug 2055285 - Remove the "Show closed/merged PR" checkbox in the GH PR view#2674

Open
dklawren wants to merge 1 commit into
mozilla-bteam:masterfrom
dklawren:2055285
Open

Bug 2055285 - Remove the "Show closed/merged PR" checkbox in the GH PR view#2674
dklawren wants to merge 1 commit into
mozilla-bteam:masterfrom
dklawren:2055285

Conversation

@dklawren

Copy link
Copy Markdown
Collaborator

Changes:

template/en/default/github/table.html.tmpl

  • Removed the block containing the #github-show-closed checkbox and its label.

web/js/github_pull_requests.js

  • Removed the showClosed state field.
  • buildRow() no longer adds bz_default_hidden to closed/merged PR rows (they now render like any other row; the github-pr-closed marker class is kept in case styling wants it later).
  • Removed the updateVisibility() method.
  • onLoad() no longer looks up the checkbox, reveals the toggle tbody, or wires the click listener — it simply renders every PR returned by the API.

No CSS changes were needed (there were no github-show-closed rules).

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the closed/merged pull-request visibility toggle and displays all GitHub pull requests by default.

Changes:

  • Removes checkbox markup and related state/event handling.
  • Stops hiding closed and merged pull-request rows.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
extensions/GitHubPullRequests/web/js/github_pull_requests.js Always renders all returned pull requests.
extensions/GitHubPullRequests/template/en/default/github/table.html.tmpl Removes the visibility toggle UI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants