Skip to content

Bug 2058413 - update k8s scriptworkers to python 3.14 - #1496

Open
jcristau wants to merge 1 commit into
mozilla-releng:masterfrom
jcristau:bug2058413
Open

Bug 2058413 - update k8s scriptworkers to python 3.14#1496
jcristau wants to merge 1 commit into
mozilla-releng:masterfrom
jcristau:bug2058413

Conversation

@jcristau

Copy link
Copy Markdown
Contributor

No description provided.

@jcristau
jcristau requested a review from a team as a code owner July 28, 2026 09:44

@bhearsum bhearsum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that pyproject.toml, the toplevel tox.ini, and script-specific tox.ini files shouldn't be updated as well? Possibly also the check kind?

(Presumably scriptworker_client and iscript still need 3.11 though?)

@jcristau

Copy link
Copy Markdown
Contributor Author

@bhearsum updated tox.ini and the check kind. I don't think we can update pyproject.toml just yet since it's global and we still have some tasks using 3.11?

@bhearsum

Copy link
Copy Markdown
Contributor

@bhearsum updated tox.ini and the check kind. I don't think we can update pyproject.toml just yet since it's global and we still have some tasks using 3.11?

Yeah, good point (I didn't realize that was just the ruff target-version when I glanced at it...).

@@ -1,5 +1,5 @@
[tox]
envlist = py311,mypy

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably maintain 3.11 testing here seeing as iscript depends on it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

envlist is just what gets run by default when you don't pass -e to tox. tox -e py311 still works and remains in CI.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, right, ty

@bhearsum

Copy link
Copy Markdown
Contributor

Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants