Do not re-sort the history of metric definitions - it's already ordered#2337
Merged
Conversation
The probeinfo service already orders the list: The first entry (index 0) is the very first. The last entry (in Python accessible by index -1) is the last. There's some edge cases where we can have multiple entries _with the same date_, because they are for the same commit. That happens after we extend the data. In this case the previous logic could reorder those fields wrongly, leading to inconsistent data.
jeddai
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The probeinfo service already orders the list:
The first entry (index 0) is the very first.
The last entry (in Python accessible by index -1) is the last.
There's some edge cases where we can have multiple entries with the same date, because they are for the same commit. That happens after we extend the data.
In this case the previous logic could reorder those fields wrongly, leading to inconsistent data