Bug #2333: Add links to use counter dashboards instead of failing to show GLAM link#2338
Merged
jeddai merged 2 commits intoJul 22, 2026
Merged
Conversation
…ing to show GLAM link
jeddai
commented
Jul 22, 2026
| content={"View this metric in the Glean Aggregated Metrics (GLAM) dashboard"} | ||
| link={"https://docs.telemetry.mozilla.org/cookbooks/glam.html"} | ||
| /> | ||
| {#if (pingData.glam_unsupported_reason || "").includes("use-counters")} |
Member
Author
There was a problem hiding this comment.
Svelte doesn't support the ? operator, apparently
travis79
approved these changes
Jul 22, 2026
| {#if (pingData.glam_unsupported_reason || "").includes("use-counters")} | ||
| Dashboards | ||
| <HelpHoverable | ||
| content={"View this metric in the appropriate Mozilla dashboards"} |
Member
There was a problem hiding this comment.
Suggested change
| content={"View this metric in the appropriate Mozilla dashboards"} | |
| content={"View this metric in the Mozilla Use-Counter dashboards"} |
Even without anything to link to in d.t.m.o, we should probably still refer to this as the "Use-Counter" to be explicit about what the "appropriate" dashboard(s) is.
| Public Dashboard | ||
| </a> | ||
| <HelpHoverable | ||
| content={"Some use counter metrics are not visible in the public dashboard"} |
Member
There was a problem hiding this comment.
Suggested change
| content={"Some use counter metrics are not visible in the public dashboard"} | |
| content={"Some Use Counter metrics are not visible in the public dashboard"} |
Let's capitalize this to match how it is referred to in other places in d.t.m.o, etc.
| Looker Dashboard | ||
| </AuthenticatedLink> | ||
| <HelpHoverable | ||
| content={"Some use counter metrics are not visible in the Looker dashboard"} |
Member
There was a problem hiding this comment.
Suggested change
| content={"Some use counter metrics are not visible in the Looker dashboard"} | |
| content={"Some Use Counter metrics are not visible in the Looker dashboard"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2333
Pull Request checklist
fixes, if applicable)