fix: bump go toolchain to 1.25.12 for the crypto/tls advisory#176
Merged
Conversation
|
🐳 Beta image published: docker pull ghcr.io/mptooling/notifycat:pr-176Built from a80f4d8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the pinned Go toolchain from 1.25.11 to 1.25.12 to clear the standard-library advisory GO-2026-5856 (crypto/tls), which
govulncheckreports as reachable from the running server and CLIs:internal/platform/github/client.go—GetPullRequest→http.Client.Do/io.ReadAll→tls.Connhandshake/readinternal/diagnostics/application/config_cli.go—List→fmt.Fprintf→tls.Conn.WriteThe pin is updated in the three places that carry it:
go.mod,justfile(the Dockergovulncheckimage), and.github/workflows/ci.yml(GO_VERSION).Notes
Toolchain-only change — no application code touched. Verified with the Docker
govulncheckstep (just vuln) on 1.25.12: No vulnerabilities found;go build ./...clean.Kept as its own single-concern PR so the advisory can be cleared on
mainindependently of the in-flight routing fix (#173) and AI feature (#175), both of which will rebase onto this.